Skip to content

fix(drive)!: invalid protocol version is using to deserialize state - #1679

Merged
shumkov merged 26 commits into
v1.0-devfrom
feat/execution_state
Jan 26, 2024
Merged

fix(drive)!: invalid protocol version is using to deserialize state#1679
shumkov merged 26 commits into
v1.0-devfrom
feat/execution_state

Conversation

@shumkov

@shumkov shumkov commented Jan 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

Currently we use latest protocol version to deserialise state. It works until current protocol version == latest protocol version, which obviously won't be always the case.

What was done?

  • Use current protocol version to deserialise the state

How Has This Been Tested?

None

Breaking Changes

We store protocol version on init chain so previously created state won't be valid

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title chore: use current protocol version to deserialize state fix: invalid protocol version is using to deserialize state Jan 20, 2024
@shumkov shumkov added this to the v1.0.0 milestone Jan 20, 2024
QuantumExplorer
QuantumExplorer requested changes Jan 22, 2024
View reviewed changes
Comment thread packages/rs-drive-abci/src/execution/engine/finalize_block_proposal/v0/mod.rs Outdated
Comment thread packages/rs-drive-abci/src/execution/storage/fetch_execution_state/mod.rs Outdated
QuantumExplorer
QuantumExplorer reviewed Jan 22, 2024
View reviewed changes
Comment thread packages/rs-drive-abci/src/execution/storage/fetch_execution_state/v0/mod.rs Outdated
QuantumExplorer
QuantumExplorer requested changes Jan 25, 2024
View reviewed changes
Comment thread packages/rs-drive-abci/src/execution/engine/initialization/init_chain/v0/mod.rs
Comment thread packages/rs-drive-abci/src/execution/storage/fetch_platform_state/mod.rs Outdated
Comment thread packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs Outdated
Comment thread packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs Outdated
QuantumExplorer
QuantumExplorer requested changes Jan 25, 2024
View reviewed changes
Comment thread packages/rs-drive-abci/src/execution/engine/initialization/init_chain/v0/mod.rs Outdated
Comment thread packages/rs-drive/src/drive/platform_state/fetch_platform_state_bytes/v0/mod.rs Outdated
Comment thread packages/rs-drive/src/drive/system/protocol_version/store_current_protocol_version.rs Outdated
QuantumExplorer
QuantumExplorer reviewed Jan 26, 2024
View reviewed changes
Comment thread packages/rs-drive/src/drive/platform_state/fetch_platform_state_bytes/v0/mod.rs Outdated
@shumkov shumkov changed the title fix: invalid protocol version is using to deserialize state fix(drive): invalid protocol version is using to deserialize state Jan 26, 2024
@shumkov
shumkov merged commit 26e775f into v1.0-dev Jan 26, 2024
@shumkov
shumkov deleted the feat/execution_state branch January 26, 2024 13:57
@shumkov shumkov changed the title fix(drive): invalid protocol version is using to deserialize state fix(drive)!: invalid protocol version is using to deserialize state Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes
@antouhou antouhou Awaiting requested review from antouhou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@shumkov @QuantumExplorer