feat(dashmate): handle docker pull error on images update - #1685
Merged
Conversation
pshenmic
requested review from
QuantumExplorer,
antouhou and
shumkov
as code owners
January 30, 2024 22:06
pshenmic
marked this pull request as draft
January 30, 2024 22:06
pshenmic
marked this pull request as ready for review
March 14, 2024 12:08
shumkov
requested changes
Apr 22, 2024
shumkov
approved these changes
May 6, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
#1684
Handle errors from the docker when doing
dashmate updateWhat was done?
updateNodeFactorydashmate updatecommandHow Has This Been Tested?
Manually + unit test
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only