feat(dapi)!: split getStatus into two endpoints

[markin-io]

Issue being fixed or feature implemented

Reworked getStatus query to not do Masternode related RPC reuqests

What was done?

Removed unnecessary and performance heavy getMnSync('status') and getMasternode('status') Core RPC calls from getStatus handler

How Has This Been Tested?

CI

Breaking Changes

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

[riongull]

Hey @markin-io could you give some more context about what this is about? It's a pretty big PR.

What's the motivation, what are the removals being replaced with, is this part of a bigger architectural change, etc.

Thanks!

[markin-io]

Hey @riongull.
The essence of this change can be seen here.

We got rid of getMnSync('status') and getMasternode('status') RPC calls since information they are providing not needed by JS wallet, but adding extra load to Core RPC.

Most of the files affected are either autogenerated protobuf files or tests.

[shumkov]

I was speaking with some people and community and it seems masternode status is something what people is using. Shall we just move it to a separate endpoint instead of removing? getMasternodeStatus? In this case it's probably make sense to rename getStatus to getBlockchainStatus.

[shumkov]

👍