Skip to content

fix(sdk): cannot connect to testnet due to FRAME_SIZE_ERROR - #1817

Merged
QuantumExplorer merged 1 commit into
fix/dapi-client-conn-pull-typefrom
fix/dash-sdk-gone
Apr 16, 2024
Merged

fix(sdk): cannot connect to testnet due to FRAME_SIZE_ERROR#1817
QuantumExplorer merged 1 commit into
fix/dapi-client-conn-pull-typefrom
fix/dash-sdk-gone

Conversation

@lklimek

@lklimek lklimek commented Apr 15, 2024

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

When connecting to testnet (which requires https), the following happens:

Transport(Status { code: Unknown, message: "h2 protocol error: http2 error: connection error detected: frame with invalid size", source: Some(tonic::transport::Error(Transport, hyper::Error(Http2, Error { kind: GoAway(b"", FRAME_SIZE_ERROR, Library) 

Everything works fine for local networks.

What was done?

Restored tonic/tls and tonic/tls-roots features, removed from dapi-grpc Cargo.toml.

How Has This Been Tested?

Using rs-platform-explorer against testnet.

Breaking Changes

TODO: check if this is compatible with Android/iOS.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek
lklimek changed the base branch from v1.0-dev to fix/dapi-client-conn-pull-type April 15, 2024 11:07
@HashEngineering

Copy link
Copy Markdown
Contributor

I have tested this PR with successful results.

The h2 protocol error no longer happens on a Mac or on Android.

@QuantumExplorer
QuantumExplorer marked this pull request as ready for review April 16, 2024 05:11
@QuantumExplorer
QuantumExplorer merged commit 057951a into fix/dapi-client-conn-pull-type Apr 16, 2024
@QuantumExplorer
QuantumExplorer deleted the fix/dash-sdk-gone branch April 16, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants