Skip to content

feat(platform)!: identity create replay protection - #1819

Merged
QuantumExplorer merged 4 commits into
v1.0-devfrom
feat/IdentityCreateReplayProtection
Apr 16, 2024
Merged

feat(platform)!: identity create replay protection#1819
QuantumExplorer merged 4 commits into
v1.0-devfrom
feat/IdentityCreateReplayProtection

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Apr 15, 2024

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

There were still issues with replay attacks on identity create state transitions, this should now fix them.

What was done?

We added a list of state transition hashes to the asset lock, so that if a state transition fails the state transition signable bytes hash is added, so that replaying the state transition would immediately fail.

How Has This Been Tested?

Added multiple tests.

Breaking Changes

This is a breaking change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer changed the title feat: identity create replay protection feat(platform)!: identity create replay protection Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants