feat(platform)!: identity create replay protection - #1819
Merged
Conversation
shumkov
requested changes
Apr 16, 2024
shumkov
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
There were still issues with replay attacks on identity create state transitions, this should now fix them.
What was done?
We added a list of state transition hashes to the asset lock, so that if a state transition fails the state transition signable bytes hash is added, so that replaying the state transition would immediately fail.
How Has This Been Tested?
Added multiple tests.
Breaking Changes
This is a breaking change.
Checklist:
For repository code-owners and collaborators only