Skip to content

feat(drive-abci): configure dir to store rejected txs - #1823

Merged
QuantumExplorer merged 3 commits into
v1.0-devfrom
feat/config-rejections
Apr 19, 2024
Merged

feat(drive-abci): configure dir to store rejected txs#1823
QuantumExplorer merged 3 commits into
v1.0-devfrom
feat/config-rejections

Conversation

@lklimek

@lklimek lklimek commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

In #1821, we store failed transactions on disk. However, the location should be configurable.

What was done?

  1. Added config variable, REJECTIONS_PATH, that points to directory where rejected transactions should be saved.
  2. Using REJECTIONS_PATH in store_transaction_failures()
  3. Set default REJECTIONS_PATH=/var/log/dash/rejected in Docker

How Has This Been Tested?

Modified check_tx to dump every tx, then started local network and verified that files are stored in /var/log/dash/rejected

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek
lklimek marked this pull request as ready for review April 19, 2024 13:20
@QuantumExplorer
QuantumExplorer merged commit dde03fc into v1.0-dev Apr 19, 2024
@QuantumExplorer
QuantumExplorer deleted the feat/config-rejections branch April 19, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants