Skip to content

feat(platform)!: ability to transfer documents - #1826

Merged
QuantumExplorer merged 31 commits into
v1.0-devfrom
feat/transferDocument
Apr 22, 2024
Merged

feat(platform)!: ability to transfer documents#1826
QuantumExplorer merged 31 commits into
v1.0-devfrom
feat/transferDocument

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented / What was done?

The ability to transfer documents between identities was a sorely missed feature, in this PR we implement a document transfer action. We also introduce the $transferredAt, $transferredAtBlockHeight and $transferredAtCoreBlockHeight.

Mutable documents can not be transferred, and transferable documents must not be mutable.

How Has This Been Tested?

A lot of Tests were added.

Breaking Changes

Their are multiple breaking changes, including having to change the serialization of documents to incorporate 9 time fields ($createdAt, $createdAtBlockHeight, $createdAtCoreBlockHeight, $updatedAt...).

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer changed the title Feat/transfer document feat(platform)!: transfer document Apr 20, 2024
@QuantumExplorer QuantumExplorer changed the title feat(platform)!: transfer document feat(platform)!: ability to transfer documents Apr 20, 2024
pauldelucia
pauldelucia previously approved these changes Apr 22, 2024
Comment thread packages/rs-dpp/src/data_contract/document_type/v0/random_document.rs Outdated
Comment thread packages/rs-sdk/src/platform/transition/transfer_document.rs Outdated
Comment thread packages/rs-sdk/src/platform/transition/transfer_document.rs Outdated
Comment thread packages/rs-sdk/src/platform/transition/transfer_document.rs Outdated
Comment thread packages/strategy-tests/src/lib.rs Outdated
Comment thread packages/strategy-tests/src/lib.rs
Comment thread packages/rs-dpp/src/data_contract/document_type/v0/mod.rs Outdated
Comment thread packages/rs-dpp/src/document/transfer.rs Outdated
QuantumExplorer and others added 5 commits April 22, 2024 20:26
…try_from_schema/v0/mod.rs

Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
…ment.rs

Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
QuantumExplorer and others added 8 commits April 22, 2024 20:28
Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
…on/state_transitions/documents_batch/action_validation/document_transfer_transition_action/structure_v0/mod.rs

Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
…on/state_transitions/documents_batch/action_validation/document_delete_transition_action/structure_v0/mod.rs

Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
…on/state_transitions/documents_batch/action_validation/document_replace_transition_action/structure_v0/mod.rs

Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
@QuantumExplorer
QuantumExplorer merged commit e71f92c into v1.0-dev Apr 22, 2024
@QuantumExplorer
QuantumExplorer deleted the feat/transferDocument branch April 22, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants