Skip to content

fix: add tls-webpki-roots to support tls on mobile (Android, iOS) - #1828

Merged
QuantumExplorer merged 1 commit into
dashpay:v1.0-devfrom
HashEngineering:fix/mobile-tls-support
Apr 23, 2024
Merged

fix: add tls-webpki-roots to support tls on mobile (Android, iOS)#1828
QuantumExplorer merged 1 commit into
dashpay:v1.0-devfrom
HashEngineering:fix/mobile-tls-support

Conversation

@HashEngineering

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

It was found that on Android, there were TLS connection errors. After investigating this issue was found with tonic
grpc/grpc-rust#1403.

What was done?

The solution is to add the feature tonic/tls-webpki-roots to the dapi-grpc crate.

How Has This Been Tested?

This change was verified on Android and Mac, though in both cases using C Bindings generated by Ferment and run using Java.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants