Skip to content

docs: update comment for data contract code range #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 3 commits into from
Mar 11, 2025
Merged

docs: update comment for data contract code range #2476

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ced8c54
docs: update comment for data contract code range
thephez Feb 19, 2025
66c32a0
Merge branch 'v2.0-dev' into fix-error-comment
thephez Feb 24, 2025
be9ee13
Merge branch 'v2.0-dev' into fix-error-comment
thephez Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/rs-dpp/src/errors/consensus/codes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ impl ErrorWithCode for BasicError {
Self::InvalidIdentifierError { .. } => 10102,
Self::ValueError(_) => 10103,

// DataContract Errors: 10200-10399
// DataContract Errors: 10200-10349

@shumkov shumkov Feb 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here not the actual codes but bounds which is make sense in terms of information for developer

@thephez thephez Feb 20, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what change you're requesting. The next category of errors (Groups) starts at 10350, so 10349 is the limit for Data Contract errors. This follows the pattern of the other comments.

Start of next error type:

            // Group Errors: 10350-10399
            Self::GroupPositionDoesNotExistError(_) => 10350,

@pauldelucia pauldelucia Feb 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shumkov

Self::DataContractMaxDepthExceedError { .. } => 10200,
Self::DuplicateIndexError { .. } => 10201,
Self::IncompatibleRe2PatternError { .. } => 10202,
Expand Down