feat: addresses on the Platform chain#2866
Merged
Merged
Conversation
Contributor
❌ gRPC Query Coverage Report |
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
QuantumExplorer
marked this pull request as draft
November 22, 2025 21:03
lklimek
reviewed
Dec 3, 2025
| fn sign(&self, key: &K, data: &[u8]) -> Result<BinaryData, ProtocolError>; | ||
|
|
||
| /// the public key bytes are only used to look up the private key | ||
| fn sign_create_witness(&self, key: &K, data: &[u8]) -> Result<AddressWitness, ProtocolError>; |
Contributor
There was a problem hiding this comment.
maybe we should move sign_create_witness() out of signer, into new trait
QuantumExplorer
changed the base branch from
v2.2-dev
to
feat/platformAddresses
December 9, 2025 01:49
QuantumExplorer
marked this pull request as ready for review
December 9, 2025 01:50
QuantumExplorer
merged commit Dec 9, 2025
ed4a544
into
feat/platformAddresses
17 of 19 checks passed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is made to merge the main bulk of the work into a branch holding the work of multiple contributors.