Skip to content

feat: addresses on the Platform chain#2866

Merged
QuantumExplorer merged 54 commits into
feat/platformAddressesfrom
feat/singleUseKeys
Dec 9, 2025
Merged

feat: addresses on the Platform chain#2866
QuantumExplorer merged 54 commits into
feat/platformAddressesfrom
feat/singleUseKeys

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Nov 22, 2025

Copy link
Copy Markdown
Member

This PR is made to merge the main bulk of the work into a branch holding the work of multiple contributors.

@github-actions

github-actions Bot commented Nov 22, 2025

Copy link
Copy Markdown
Contributor

❌ gRPC Query Coverage Report

================================================================================
gRPC Query Coverage Report - NEW QUERIES ONLY
================================================================================

Total queries in proto: 49
Previously known queries: 47
New queries found: 2

================================================================================

New Query Implementation Status:
--------------------------------------------------------------------------------
✗ getAddressInfo                                NOT FOUND
✗ getAddressesInfos                             NOT FOUND

================================================================================
Summary:
--------------------------------------------------------------------------------
New queries implemented: 0 (0.0%)
New queries missing: 2 (100.0%)

Total known queries: 49
  - Implemented: 44
  - Not implemented: 4
  - Excluded: 1

Not implemented queries:
  - getAddressInfo
  - getAddressesInfos
  - getConsensusParams
  - getTokenPreProgrammedDistributions

Missing NEW queries:
  - getAddressInfo
  - getAddressesInfos

@coderabbitai

coderabbitai Bot commented Nov 22, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/singleUseKeys

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@QuantumExplorer
QuantumExplorer marked this pull request as draft November 22, 2025 21:03
fn sign(&self, key: &K, data: &[u8]) -> Result<BinaryData, ProtocolError>;

/// the public key bytes are only used to look up the private key
fn sign_create_witness(&self, key: &K, data: &[u8]) -> Result<AddressWitness, ProtocolError>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should move sign_create_witness() out of signer, into new trait

@QuantumExplorer
QuantumExplorer changed the base branch from v2.2-dev to feat/platformAddresses December 9, 2025 01:49
@QuantumExplorer
QuantumExplorer marked this pull request as ready for review December 9, 2025 01:50
@QuantumExplorer
QuantumExplorer merged commit ed4a544 into feat/platformAddresses Dec 9, 2025
17 of 19 checks passed
@QuantumExplorer
QuantumExplorer deleted the feat/singleUseKeys branch December 9, 2025 01:51
@thephez thephez added this to the v3.0 milestone Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants