ci: fix NPM publish in release#2923
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
shumkov
added a commit
that referenced
this pull request
May 20, 2026
The release-npm job set up Node twice in the same runner: once for the build with the composite action default, then again right before `npm publish` with `node-version: 24` to satisfy trusted-publishers OIDC (npm 11.5.1+ ships only with Node 24+). That second call dates back to #2923, when the composite action still defaulted to Node 20. Since then the composite default has been bumped to 24.14.1, so both calls install the same Node binary and the second call only re-runs `yarn install --inline-builds`. The re-run is also what broke the v3.1.0-dev.2 release: the previous override `node-version: 24` widened the pin and let actions/setup-node resolve to 24.15.0 from the runner cache. 24.15.0 ships a regression in the ESM CJS translator that raises EBADF during native postinstall scripts (bufferutil, utf-8-validate, unrs-resolver, @pshenmic/zeromq). Dropping the second Setup Node.JS step removes the bug class entirely and saves ~30s per release run. A short comment above the surviving Setup Node.JS step records the Node 24+ requirement so future maintainers do not lower the version. The companion verify workflow introduced in the first commit on this branch is no longer needed and has been removed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We are getting an error on NPM publish due to the expiration of our access token.
What was done?
How Has This Been Tested?
I'm going to released new version
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only