-
Notifications
You must be signed in to change notification settings - Fork 56
feat(sdk): support platform address state transitions in JS SDK #2931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shumkov
merged 13 commits into
v3.0-dev
from
feat/sdk/platform-addresses-state-transitions
Dec 27, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
eb1ef25
feat(sdk): query platform addresses in JS SDK
shumkov fb48d6a
Merge branch 'v3.0-dev' into feat/sdk/platform-addresses-state-transi…
shumkov 9f71fab
Merge branch 'v3.0-dev' into feat/sdk/platform-addresses-state-transi…
shumkov b8ec67b
feat: add other state transitions
shumkov bdb1080
docs: update doc blocks
shumkov bf23e8e
test: remove reduntant test
shumkov 7976d6f
refactor: remove unnecessary code
shumkov 1960141
refactor: move signer
shumkov fb78f88
refactor: use serde to deserialize settings
shumkov 571a6f3
refactor: make things better
shumkov 91dfba0
refactor: remove unnecessary code
shumkov dc885f7
feat: support optinal output amount
shumkov da2a86b
feat: derive address from key
shumkov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: dashpay/platform
Length of output: 88
🏁 Script executed:
Repository: dashpay/platform
Length of output: 42
🏁 Script executed:
Repository: dashpay/platform
Length of output: 88
🏁 Script executed:
Repository: dashpay/platform
Length of output: 762
🏁 Script executed:
Repository: dashpay/platform
Length of output: 42
🏁 Script executed:
Repository: dashpay/platform
Length of output: 521
🏁 Script executed:
Repository: dashpay/platform
Length of output: 845
🏁 Script executed:
# Read the test file to see actual return values cat packages/js-evo-sdk/tests/unit/facades/addresses.spec.mjsRepository: dashpay/platform
Length of output: 10867
🏁 Script executed:
# Read the Rust source for addressFundsTransfer cat packages/wasm-sdk/src/state_transitions/addresses.rsRepository: dashpay/platform
Length of output: 38593
Return type does not match test expectations.
The declared return type
Promise<Map<wasm.PlatformAddress, wasm.PlatformAddressInfo>>contradicts what the test file expects. Tests stubaddressFundsTransferto return a discriminated union object (lines 22-25, 105-108) with atypefield containing either'VerifiedAddressInfos'(withaddressInfosarray) or'Success'(withmessagestring), not a Map. Update the return type infacade.tsto match the actual WASM SDK return shape, or verify that the WASM binding's return type definition is correct.🤖 Prompt for AI Agents