Skip to content

fix(dpp): add missing #[test] attribute to should_set_empty_schema_defs #3101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shumkov merged 2 commits into from
Feb 22, 2026
Merged

fix(dpp): add missing #[test] attribute to should_set_empty_schema_defs #3101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e015343
fix(dpp): add missing #[test] attribute to should_set_empty_schema_defs
thepastaclaw Feb 18, 2026
3762dc7
test(dpp): assert document_types preserved after clearing schema_defs
thepastaclaw Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions packages/rs-dpp/src/data_contract/v0/methods/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ mod test {
assert_eq!(defs_map.as_ref(), data_contract.schema_defs())
}

#[test]
fn should_set_empty_schema_defs() {
let platform_version = PlatformVersion::latest();

Expand All @@ -175,13 +176,25 @@ mod test {

let defs_map = Some(defs.into_btree_string_map().expect("should convert to map"));

let schema = platform_value!({
"type": "object",
"properties": {
"a": {
"type": "string",
"maxLength": 10,
"position": 0
}
},
"additionalProperties": false,
});

let serialization_format = DataContractInSerializationFormatV0 {
id: Identifier::random(),
config,
version: 0,
owner_id: Default::default(),
schema_defs: defs_map,
document_schemas: Default::default(),
document_schemas: BTreeMap::from([("document_type_name".to_string(), schema)]),
};

let mut data_contract = DataContractV0::try_from_platform_versioned(
Expand All @@ -196,6 +209,11 @@ mod test {
.set_schema_defs(None, true, &mut vec![], platform_version)
.expect("should set defs");

assert_eq!(None, data_contract.schema_defs())
assert_eq!(None, data_contract.schema_defs());
assert_eq!(
1,
data_contract.document_types().len(),
"document types should be preserved after clearing schema defs"
);
}
}
22 changes: 20 additions & 2 deletions packages/rs-dpp/src/data_contract/v1/methods/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ mod test {
assert_eq!(defs_map.as_ref(), data_contract.schema_defs())
}

#[test]
fn should_set_empty_schema_defs() {
let platform_version = PlatformVersion::latest();

Expand All @@ -175,13 +176,25 @@ mod test {

let defs_map = Some(defs.into_btree_string_map().expect("should convert to map"));

let schema = platform_value!({
"type": "object",
"properties": {
"a": {
"type": "string",
"maxLength": 10,
"position": 0
}
},
"additionalProperties": false,
});

let serialization_format = DataContractInSerializationFormatV0 {
id: Identifier::random(),
config,
version: 0,
owner_id: Default::default(),
schema_defs: defs_map,
document_schemas: Default::default(),
document_schemas: BTreeMap::from([("document_type_name".to_string(), schema)]),
};

let mut data_contract = DataContractV1::try_from_platform_versioned(
Expand All @@ -196,6 +209,11 @@ mod test {
.set_schema_defs(None, true, &mut vec![], platform_version)
.expect("should set defs");

assert_eq!(None, data_contract.schema_defs())
assert_eq!(None, data_contract.schema_defs());
assert_eq!(
1,
data_contract.document_types().len(),
"document types should be preserved after clearing schema defs"
);
}
}
Loading