fix(drive): match min_depth between prove and verify for trunk query#3199
Conversation
The prove side passes `min_depth: Some(min_depth)` from the platform version config, but the verify side was passing `min_depth: None`. This mismatch would cause proof verification failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "3376a36209d3a3ea720517b4b3f6a8eae85550e85d68d292034ddc5cac18c541"
)Xcode manual integration:
|
Issue being fixed or feature implemented
The prove side of
prove_nullifiers_trunk_query_v0passesmin_depth: Some(min_depth)from the platform version config, but the verify side (verify_nullifiers_trunk_query_v0) was passingmin_depth: None. This parameter mismatch would cause proof verification failures.What was done?
Updated
verify_nullifiers_trunk_query_v0to readnullifiers_query_min_depthfrom the platform version and passmin_depth: Some(min_depth), matching the prove side.How Has This Been Tested?
cargo check -p drive— compiles cleanlyBreaking Changes
None.
Checklist: