Skip to content

fix(drive): match min_depth between prove and verify for trunk query#3199

Merged
QuantumExplorer merged 1 commit into
feat/zk-drivefrom
fix/trunk-query-min-depth-mismatch
Mar 6, 2026
Merged

fix(drive): match min_depth between prove and verify for trunk query#3199
QuantumExplorer merged 1 commit into
feat/zk-drivefrom
fix/trunk-query-min-depth-mismatch

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

The prove side of prove_nullifiers_trunk_query_v0 passes min_depth: Some(min_depth) from the platform version config, but the verify side (verify_nullifiers_trunk_query_v0) was passing min_depth: None. This parameter mismatch would cause proof verification failures.

What was done?

Updated verify_nullifiers_trunk_query_v0 to read nullifiers_query_min_depth from the platform version and pass min_depth: Some(min_depth), matching the prove side.

How Has This Been Tested?

  • cargo check -p drive — compiles cleanly

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

The prove side passes `min_depth: Some(min_depth)` from the platform
version config, but the verify side was passing `min_depth: None`.
This mismatch would cause proof verification failures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b1a7ed45-3114-4788-bd49-5f85648bbfc6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/trunk-query-min-depth-mismatch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

✅ DashSDKFFI.xcframework built for this PR.

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "3376a36209d3a3ea720517b4b3f6a8eae85550e85d68d292034ddc5cac18c541"
)

Xcode manual integration:

  • Download 'DashSDKFFI.xcframework' artifact from the run link above.
  • Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
  • If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

@QuantumExplorer
QuantumExplorer merged commit 743faeb into feat/zk-drive Mar 6, 2026
5 checks passed
@QuantumExplorer
QuantumExplorer deleted the fix/trunk-query-min-depth-mismatch branch March 6, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant