fix(drive): correct tree types in shielded pool estimated costs#3200
Conversation
- Nullifiers tree type: NormalTree → ProvableCountTree (matches initialization which uses empty_provable_count_tree()) - Pool children weights: count_trees_weight=1 for nullifiers, non_sum_trees_weight=1 for anchors (was 0+2) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "efe60dabfe9332552ceae7753cb860416aa7bcf48a95c040909dc82739130197"
)Xcode manual integration:
|
Issue being fixed or feature implemented
The fee estimation for the shielded pool used incorrect tree types, causing inaccurate cost calculations.
What was done?
NormalTree→ProvableCountTreeto matchempty_provable_count_tree()used in initializationcount_trees_weight: 1for nullifiers,non_sum_trees_weight: 1for anchors only (wascount_trees_weight: 0, non_sum_trees_weight: 2)How Has This Been Tested?
cargo check -p drive— compiles cleanlyBreaking Changes
None.
Checklist: