Skip to content

fix(drive): correct tree types in shielded pool estimated costs#3200

Merged
QuantumExplorer merged 1 commit into
feat/zk-drivefrom
fix/estimated-costs-tree-types
Mar 6, 2026
Merged

fix(drive): correct tree types in shielded pool estimated costs#3200
QuantumExplorer merged 1 commit into
feat/zk-drivefrom
fix/estimated-costs-tree-types

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

The fee estimation for the shielded pool used incorrect tree types, causing inaccurate cost calculations.

What was done?

  • Nullifiers tree: NormalTreeProvableCountTree to match empty_provable_count_tree() used in initialization
  • Pool children weights: count_trees_weight: 1 for nullifiers, non_sum_trees_weight: 1 for anchors only (was count_trees_weight: 0, non_sum_trees_weight: 2)

How Has This Been Tested?

  • cargo check -p drive — compiles cleanly

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

- Nullifiers tree type: NormalTree → ProvableCountTree (matches
  initialization which uses empty_provable_count_tree())
- Pool children weights: count_trees_weight=1 for nullifiers,
  non_sum_trees_weight=1 for anchors (was 0+2)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b6696138-2dca-4db2-804f-6c8e8e891086

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/estimated-costs-tree-types

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

✅ DashSDKFFI.xcframework built for this PR.

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "efe60dabfe9332552ceae7753cb860416aa7bcf48a95c040909dc82739130197"
)

Xcode manual integration:

  • Download 'DashSDKFFI.xcframework' artifact from the run link above.
  • Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
  • If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

@QuantumExplorer
QuantumExplorer merged commit 5218ddf into feat/zk-drive Mar 6, 2026
5 checks passed
@QuantumExplorer
QuantumExplorer deleted the fix/estimated-costs-tree-types branch March 6, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant