Skip to content

fix(drive): replace unchecked integer casts with try_from#3201

Merged
QuantumExplorer merged 1 commit into
feat/zk-drivefrom
fix/unchecked-integer-casts
Mar 6, 2026
Merged

fix(drive): replace unchecked integer casts with try_from#3201
QuantumExplorer merged 1 commit into
feat/zk-drivefrom
fix/unchecked-integer-casts

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Two unchecked integer casts could silently truncate values:

  • nullifiers.len() as i64 in store_nullifiers (overflow on large counts)
  • nullifiers.len() as u16 in verify_shielded_nullifiers (truncation above 65535)

What was done?

Replaced both with try_from() that returns proper errors instead of silently truncating.

How Has This Been Tested?

  • cargo check -p drive — compiles cleanly

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

- store_nullifiers: `nullifiers.len() as i64` → `i64::try_from()`
- verify_shielded_nullifiers: `nullifiers.len() as u16` → `u16::try_from()`

Both now return proper errors instead of silently truncating.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3d3b5277-f7e2-482f-91be-19333d6e4ebb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/unchecked-integer-casts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@QuantumExplorer
QuantumExplorer merged commit 357e9b0 into feat/zk-drive Mar 6, 2026
5 checks passed
@QuantumExplorer
QuantumExplorer deleted the fix/unchecked-integer-casts branch March 6, 2026 10:56
@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

✅ DashSDKFFI.xcframework built for this PR.

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "4412837c554382cc2d071532e473315c0f0d6eb763d0843d8fa05f02324902e2"
)

Xcode manual integration:

  • Download 'DashSDKFFI.xcframework' artifact from the run link above.
  • Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
  • If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant