Skip to content

fix(drive): import nullifier constants instead of duplicating them#3202

Merged
QuantumExplorer merged 1 commit into
feat/zk-drivefrom
fix/duplicated-constants
Mar 6, 2026
Merged

fix(drive): import nullifier constants instead of duplicating them#3202
QuantumExplorer merged 1 commit into
feat/zk-drivefrom
fix/duplicated-constants

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

NULLIFIERS_KEY_U8 and COMPACTED_NULLIFIERS_KEY_U8 were defined locally in verify modules instead of importing from saved_block_transactions::queries. If the canonical value changes, these local copies would silently diverge, breaking proof verification.

What was done?

Replaced local constant definitions with imports from crate::drive::saved_block_transactions.

How Has This Been Tested?

  • cargo check -p drive — compiles cleanly

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

Replace locally-defined NULLIFIERS_KEY_U8 and COMPACTED_NULLIFIERS_KEY_U8
with imports from saved_block_transactions::queries to avoid divergence.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c34328be-31bc-419e-81e9-995d0ab4e338

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/duplicated-constants

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@QuantumExplorer
QuantumExplorer merged commit d1c1a61 into feat/zk-drive Mar 6, 2026
4 of 5 checks passed
@QuantumExplorer
QuantumExplorer deleted the fix/duplicated-constants branch March 6, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant