Skip to content

fix(drive): guard against max_elements=0 in encrypted notes verification #3204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 1 commit into from
Mar 6, 2026
Merged

fix(drive): guard against max_elements=0 in encrypted notes verification #3204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/rs-drive/src/verify/shielded/verify_shielded_encrypted_notes/v0/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,15 @@ impl Drive {
verify_subset_of_proof: bool,
platform_version: &PlatformVersion,
) -> Result<(RootHash, Vec<(Vec<u8>, Vec<u8>, Vec<u8>)>), Error> {
if max_elements == 0 {
return Err(Error::Drive(DriveError::CorruptedElementType(
"max_elements must be greater than zero",
)));
}

// start_index must be chunk-aligned (multiple of max_elements)
let chunk_size = max_elements as u64;
if chunk_size > 0 && start_index % chunk_size != 0 {
if start_index % chunk_size != 0 {
return Err(Error::Drive(DriveError::CorruptedElementType(
"start_index is not chunk-aligned; must be a multiple of max_elements",
)));
Expand Down
Loading