fix(drive): use RootTree enum instead of magic number 72u8#3205
Conversation
Replace hardcoded `vec![72u8]` with `vec![RootTree::SpentAssetLockTransactions as u8]` in the ShieldFromAssetLock proof query path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "6d9ff36e99f29fd7a39626bd2bb897c668c64aa4a17d680613517571f99b1bfb"
)Xcode manual integration:
|
Issue being fixed or feature implemented
The ShieldFromAssetLock proof query hardcoded
72u8for the SpentAssetLockTransactions root tree path. If the enum value ever changes, this would silently break.What was done?
Replaced
vec![72u8]withvec![RootTree::SpentAssetLockTransactions as u8].How Has This Been Tested?
cargo check -p drive— compiles cleanlyBreaking Changes
None.
Checklist: