feat(drive): adapt to grovedb SubelementsDeletionBehavior per-op enum#3217
Merged
QuantumExplorer merged 11 commits intoMar 9, 2026
Merged
Conversation
Upgrade grovedb to rev a20add8d which replaces global BatchApplyOptions fields (allow_deleting_non_empty_trees, deleting_non_empty_trees_returns_error) with per-op SubelementsDeletionBehavior on DeleteTree operations. - Use DontCheck for batch_delete_up_tree_while_empty (caller verifies emptiness) - Use DeleteChildren for delete_proposers_tree (intentionally non-empty) - Update GroveOp::DeleteTree pattern matches for new 2-field variant - Remove obsolete BatchApplyOptions fields - Update proof size assertions for latest protocol version - Update fee assertions in drive-abci tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…n-behavior' into feat/grovedb-subelements-deletion-behavior
These fee changes were from an older grovedb rev and are no longer needed with rev 2c9117cf. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…om:dashpay/platform into feat/grovedb-subelements-deletion-behavior
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Each changed assertion now notes the previous value and that the increase comes from KVValueHashFeatureTypeWithChildHash in grovedb proofs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…om:dashpay/platform into feat/grovedb-subelements-deletion-behavior
Contributor
✅ gRPC Query Coverage Report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2c9117cfwhich replaces globalBatchApplyOptionsfields (allow_deleting_non_empty_trees,deleting_non_empty_trees_returns_error) with per-opSubelementsDeletionBehaviorenum onDeleteTreeoperationsDontCheckforbatch_delete_up_tree_while_empty(caller already verifies emptiness),DeleteChildrenfordelete_proposers_tree(intentionally non-empty tree)GroveOp::DeleteTreepattern matches for the new 2-field variantBatchApplyOptionsfieldsIssue being addressed
Adapts platform to grovedb PR #634 which moves deletion behavior from a batch-global option to a per-operation setting.
Test plan
cargo check -p drivetest_initial_state_structure_proper_heights_in_latest_protocol_version— passes🤖 Generated with Claude Code