fix(ci): add rs-dash-async to Docker build context#3543
Conversation
PR #3497 introduced packages/rs-dash-async as a workspace member but did not update the Dockerfile COPY blocks. Cargo cannot resolve the workspace because the manifest at /platform/packages/rs-dash-async/Cargo.toml is missing inside the build container, causing the nightly Docker image builds (Drive, RS-DAPI, Dashmate helper) to fail with: failed to load manifest for dependency `dash-async` failed to read `/platform/packages/rs-dash-async/Cargo.toml` Add packages/rs-dash-async to the four COPY --parents blocks (build-planner, build-drive-abci sources, wasm-dpp deps, build-rs-dapi sources) so the crate is present whenever cargo touches the workspace. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 35 minutes and 45 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Review complete (commit dcc38c0) |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
PR is a minimal, correct CI fix that adds packages/rs-dash-async to the four Dockerfile COPY --parents blocks (lines 384, 476, 595, 838). The addition matches the workspace membership in Cargo.toml and the path dependencies declared by rs-sdk, rs-context-provider, and rs-sdk-trusted-context-provider. No actionable issues found.
Reviewed commit: dcc38c0
Issue being fixed or feature implemented
The nightly Docker image builds (Drive, RS-DAPI, Dashmate helper) on
v3.1-devare failing with:Failing run: https://github.com/dashpay/platform/actions/runs/24942936277/job/73039526871
PR #3497 introduced
packages/rs-dash-asyncas a workspace member (and as a path dependency ofrs-sdk,rs-context-provider, andrs-sdk-trusted-context-provider) but did not update theDockerfile. Cargo cannot resolve the workspace inside the build container because the manifest is missing, so every Rust image build aborts before compilation starts.What was done?
Added
packages/rs-dash-asyncto all fourCOPY --parentsblocks in theDockerfile:build-planner— sources used bycargo chef preparebuild-drive-abci— sources used to builddrive-abcibuild-wasm-dpp— sources used by the wasm-dpp / yarn buildbuild-rs-dapi— sources used to buildrs-dapiThe crate is inserted next to
packages/rs-dash-event-busto keep the relatedrs-dash-*workspace members grouped.How Has This Been Tested?
Cargo.tomllistspackages/rs-dash-asyncas a member.rs-sdk,rs-context-provider, andrs-sdk-trusted-context-providerdeclaredash-async = { path = "../rs-dash-async" }— these crates are already in each affected COPY block.packages/rs-dash-async \.Breaking Changes
None.
Checklist: