Skip to content

fix(ci): add rs-dash-async to Docker build context#3543

Merged
QuantumExplorer merged 1 commit into
v3.1-devfrom
fix/dockerfile-rs-dash-async
Apr 27, 2026
Merged

fix(ci): add rs-dash-async to Docker build context#3543
QuantumExplorer merged 1 commit into
v3.1-devfrom
fix/dockerfile-rs-dash-async

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

The nightly Docker image builds (Drive, RS-DAPI, Dashmate helper) on v3.1-dev are failing with:

failed to load manifest for dependency `dash-async`
failed to read `/platform/packages/rs-dash-async/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

Failing run: https://github.com/dashpay/platform/actions/runs/24942936277/job/73039526871

PR #3497 introduced packages/rs-dash-async as a workspace member (and as a path dependency of rs-sdk, rs-context-provider, and rs-sdk-trusted-context-provider) but did not update the Dockerfile. Cargo cannot resolve the workspace inside the build container because the manifest is missing, so every Rust image build aborts before compilation starts.

What was done?

Added packages/rs-dash-async to all four COPY --parents blocks in the Dockerfile:

  1. build-planner — sources used by cargo chef prepare
  2. build-drive-abci — sources used to build drive-abci
  3. build-wasm-dpp — sources used by the wasm-dpp / yarn build
  4. build-rs-dapi — sources used to build rs-dapi

The crate is inserted next to packages/rs-dash-event-bus to keep the related rs-dash-* workspace members grouped.

How Has This Been Tested?

  • Verified the workspace Cargo.toml lists packages/rs-dash-async as a member.
  • Verified rs-sdk, rs-context-provider, and rs-sdk-trusted-context-provider declare dash-async = { path = "../rs-dash-async" } — these crates are already in each affected COPY block.
  • Verified all four COPY blocks now contain packages/rs-dash-async \.
  • CI on the PR will exercise the actual Docker image builds.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

PR #3497 introduced packages/rs-dash-async as a workspace member but did
not update the Dockerfile COPY blocks. Cargo cannot resolve the workspace
because the manifest at /platform/packages/rs-dash-async/Cargo.toml is
missing inside the build container, causing the nightly Docker image
builds (Drive, RS-DAPI, Dashmate helper) to fail with:

    failed to load manifest for dependency `dash-async`
    failed to read `/platform/packages/rs-dash-async/Cargo.toml`

Add packages/rs-dash-async to the four COPY --parents blocks (build-planner,
build-drive-abci sources, wasm-dpp deps, build-rs-dapi sources) so the
crate is present whenever cargo touches the workspace.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@QuantumExplorer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 35 minutes and 45 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 35 minutes and 45 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 751e0d10-97b4-42f9-b89f-be181f3b0841

📥 Commits

Reviewing files that changed from the base of the PR and between 461d2f4 and dcc38c0.

📒 Files selected for processing (1)
  • Dockerfile
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dockerfile-rs-dash-async

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added this to the v3.1.0 milestone Apr 26, 2026
@thepastaclaw

thepastaclaw commented Apr 26, 2026

Copy link
Copy Markdown
Collaborator

✅ Review complete (commit dcc38c0)

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

PR is a minimal, correct CI fix that adds packages/rs-dash-async to the four Dockerfile COPY --parents blocks (lines 384, 476, 595, 838). The addition matches the workspace membership in Cargo.toml and the path dependencies declared by rs-sdk, rs-context-provider, and rs-sdk-trusted-context-provider. No actionable issues found.

Reviewed commit: dcc38c0

@QuantumExplorer
QuantumExplorer merged commit f4d3582 into v3.1-dev Apr 27, 2026
33 of 35 checks passed
@QuantumExplorer
QuantumExplorer deleted the fix/dockerfile-rs-dash-async branch April 27, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants