Skip to content

ci: drop '!path' negation patterns from JS package filter #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 1 commit into from
May 5, 2026
Merged

ci: drop '!path' negation patterns from JS package filter #3592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions .github/package-filters/js-packages-no-workflows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,18 @@
- packages/rs-platform-version/**
- packages/rs-platform-versioning/**
- packages/rs-dpp/**
# Exclude Rust test files — they don't affect WASM builds
- '!packages/rs-dpp/**/tests.rs'
- '!packages/rs-dpp/**/tests/**'
- '!packages/rs-dpp/**/test_helpers/**'
- '!packages/rs-dpp/**/test_utils.rs'
- '!packages/rs-dpp/**/test_utils/**'
# NOTE: do not add `!packages/rs-dpp/**/tests.rs` style negation
# patterns here. The dispatcher in `tests.yml` runs these filters
# via `dorny/paths-filter@v3` with the default
# `predicate-quantifier: some`, under which each pattern (including
# `!`-prefixed ones) is OR'd independently. A `!` pattern then
# "matches" every file that doesn't match the negated path — i.e.
# virtually every file in the repo — which trips this filter on
# Swift-only / Rust-only changes and cascades through every other
# filter that aliases `*wasm-dpp` (dapi, dapi-client, wallet-lib,
# dash, dashmate, platform-test-suite, …). Cheaper to over-trigger
# the WASM tests on rs-dpp test-only edits than to mis-trigger
# half the JS test matrix on every PR.

'@dashevo/wasm-dpp2': &wasm-dpp2
- packages/wasm-dpp2/**
Expand Down Expand Up @@ -96,13 +102,10 @@ dashmate:
- packages/rs-platform-version/**
- packages/rs-dash-platform-macros/**
- packages/dapi-grpc/**
# Exclude Rust test files — they don't affect WASM builds
- '!packages/rs-drive-proof-verifier/**/tests.rs'
- '!packages/rs-drive-proof-verifier/**/tests/**'
- '!packages/rs-sdk/**/tests.rs'
- '!packages/rs-sdk/**/tests/**'
- '!packages/rs-dapi-client/**/tests.rs'
- '!packages/rs-dapi-client/**/tests/**'
# NOTE: do not add `!path` negation patterns here — see the long
# explanation on `@dashevo/wasm-dpp` above. Same `dorny/paths-filter@v3`
# + `predicate-quantifier: some` interaction trips this filter on
# unrelated changes and cascades into every consumer (`*wasm-sdk`).

'@dashevo/evo-sdk': &evo-sdk
- packages/js-evo-sdk/**
Expand Down
Loading