-
Notifications
You must be signed in to change notification settings - Fork 56
feat(swift-sdk): platform-to-platform send #3626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QuantumExplorer
merged 8 commits into
v3.1-dev
from
feat/swift-send-platform-to-platform
May 12, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9f0b5d6
feat(swift-sdk): platform-to-platform send
llbartekll 1ed514a
chore(swift-sdk): tighten send-flow API + error handling
llbartekll b31da16
fix(rs-platform-wallet): hydrate account.address_credit_balance on re…
llbartekll e9181df
chore(swift-sdk): drop pre-send watermark/sync workaround
llbartekll 4d4c13b
fix(swift-sdk): persist transfer balance changes + reject duplicate o…
llbartekll 4f28a5b
fix(rs-platform-wallet): persist transfer changeset after a successfu…
llbartekll f48497b
chore: scrub session-specific terminology from comments
llbartekll 16769c9
chore(swift-sdk): address PR review comments (HRP, Decimal parsing, c…
llbartekll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Blocking: Transfer persists proof entries for non-owned recipient addresses as sender-account rows
Sdk::transfer_address_fundsreturnsAddressInfosforinputs ∪ outputs(seeexpected_addresses = inputs.keys().chain(outputs.keys()).copied().collect()inrs-sdk/src/platform/transition/transfer_address_funds.rs:94and the equality enforcement incollect_address_infos_from_proof). The loop intransfer.rs:103-137then iterates every returned address, callsset_address_credit_balanceon the sender account, and — when the address is not found in that account's HD pool — falls back toaddress_index = 0(line 129) and pushes the entry intocs. The newself.persister.store(cs.clone().into())on line 156 makes that durable. For a normal external send, the recipient's proved post-transfer balance is now persisted as if it lived in the sender's account at index 0. If the recipient hash happens to exist in another account on the same wallet, the persisted row's(wallet_id, account_index, address_index)coordinates are silently rewritten to the sender's. Filter the loop to only addresses owned byaccount_index(i.e. only push when thefind_mapactually finds anaddress_index), or only whenaddrcame from the originalinputsset.source: ['codex-general']
🤖 Fix this with AI agents