Skip to content

ci: clean stale Swift SDK FFI headers#3660

Closed
vivekgsharma wants to merge 1 commit into
v3.1-devfrom
codex/clean-swift-sdk-ffi-headers
Closed

ci: clean stale Swift SDK FFI headers#3660
vivekgsharma wants to merge 1 commit into
v3.1-devfrom
codex/clean-swift-sdk-ffi-headers

Conversation

@vivekgsharma

Copy link
Copy Markdown
Collaborator

Summary

  • Prune stale generated FFI header directories before injecting the DashSDKFFI umbrella header.
  • Fail fast if any expected current FFI header is missing.
  • Preserve the Rust target cache while preventing removed headers, such as the old dash-spv-ffi header directory, from leaking into the xcframework.

Validation

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9511af11-0241-4c52-9683-625339f66de2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/clean-swift-sdk-ffi-headers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added this to the v3.1.0 milestone May 18, 2026
@vivekgsharma vivekgsharma changed the title [codex] Clean stale Swift SDK FFI headers ci: clean stale Swift SDK FFI headers May 18, 2026
@QuantumExplorer QuantumExplorer removed this from the v4.0.0 milestone Jun 1, 2026
@vivekgsharma

Copy link
Copy Markdown
Collaborator Author

Closing this draft as superseded by #3666. The stale Swift SDK FFI header issue is already handled in v3.1-dev by ci(swift-sdk): prune orphaned FFI header subdirs in build_ios.sh, which added the INCLUDED_CRATES source of truth, prunes orphan include dirs, validates expected headers, and regenerates the umbrella header from that list. This PR is now conflicting and no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants