Skip to content

ci(release): fix dashmate deb pack by configuring oclif targets #3713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 1 commit into from
May 20, 2026
Merged

ci(release): fix dashmate deb pack by configuring oclif targets #3713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/dashmate/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,17 @@
],
"commands": "./src/commands",
"bin": "dashmate",
"update": {
"node": {
"targets": [
"linux-x64",
"linux-arm64",
"win32-x64",
"darwin-x64",
"darwin-arm64"
]
}
},
"macos": {
"identifier": "org.dash.dashmate",
"sign": "'Developer ID Installer: The Dash Foundation, Inc.'"
Expand Down
14 changes: 5 additions & 9 deletions scripts/pack_dashmate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,15 @@ fi
FLAGS=""

# Node 24+ does not publish 32-bit binaries (linux-armv7l, win-x86), so we
# must explicitly drop those targets from oclif's default lists; otherwise
# `oclif pack` 404s while downloading the embedded Node runtime.
# - tarballs default: oclif builds whatever we pass; we previously passed
# `linux-arm` (= armv7l). Replace with linux-arm64.
# - deb default targets: linux-x64, linux-arm (armv7l), linux-arm64 — drop arm.
# - win default targets: win32-x64, win32-x86 — drop x86.
# must drop those targets from oclif's defaults; otherwise `oclif pack` 404s
# while downloading the embedded Node runtime.
# - `tarballs` and `win` accept `--targets`, so we override on the command line.
# - `oclif pack deb` has no `--targets` flag; its linux targets come from
# `oclif.update.node.targets` in packages/dashmate/package.json.
case "$COMMAND" in
tarballs)
FLAGS="--no-xz --targets=linux-arm64,linux-x64"
;;
deb)
FLAGS="--targets=linux-x64,linux-arm64"
;;
win)
FLAGS="--targets=win32-x64"
;;
Expand Down
Loading