ci(release): configure oclif update targets in package.json, drop --targets for deb

[shumkov]

Summary

• Move the dashmate pack target list from script flags to oclif.update.node.targets in packages/dashmate/package.json.
• Revert scripts/pack_dashmate.sh to only set --targets for the tarballs subcommand.

Background

#3709 tried to restrict dashmate pack targets by passing --targets=linux-x64,linux-arm64 to oclif pack deb. That fixed tarballs and win, but deb still failed on v3.1.0-dev.4:

Error: Nonexistent flag: --targets=linux-x64,linux-arm64
Process completed with exit code 2

In oclif 4.0.3, --targets is accepted by pack tarballs and pack win but not pack deb. Inconsistent CLI surface.

The portable way to restrict targets across all pack subcommands is the oclif.update.node.targets field in package.json. Each subcommand filters that list to its own platform prefix (linux-* for deb, win32-* for win, darwin-* for macos). pack tarballs builds for every configured target, which is why it still needs a --targets override to stay linux-only.

Test plan

• CI green on this PR.
• Next release run shows all four Release Dashmate packages jobs ✓.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • Enhanced multi-platform support for node updates across Windows, macOS, and Linux.
  • Improved release build process to support both x64 and ARM64 architectures on all platforms.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fa98f060-c3ee-4f3c-8a52-0f13571ba378

📥 Commits

Reviewing files that changed from the base of the PR and between ac90e10 and 7aecc74.

📒 Files selected for processing (2)

• packages/dashmate/package.json
• scripts/pack_dashmate.sh

---

📝 Walkthrough

Walkthrough

This PR configures official Node update platforms for the dashmate oclif CLI by adding an oclif.update.node.targets section in package.json, and updates the pack script to align Linux tarball builds with the newly defined platform matrix, changing linux-arm to the correct linux-arm64.

Changes

Build platform targets configuration

Layer / File(s)	Summary
Node update targets and Linux build alignment packages/dashmate/package.json, scripts/pack_dashmate.sh	oclif.update.node.targets configuration specifies five supported platforms (linux-x64, linux-arm64, win32-x64, darwin-x64, darwin-arm64). pack_dashmate.sh tarballs command targets are updated from linux-arm,linux-x64 to linux-arm64,linux-x64 with documentation explaining that oclif pack tarballs is limited to Linux while deb/win/macos packaging relies on oclif.update.node.targets filtering.

Possibly related PRs

• dashpay/platform#3713: Both PRs modify packages/dashmate/package.json to set oclif.update.node.targets and adjust scripts/pack_dashmate.sh tarballs and target handling to align Linux outputs with those oclif-configured targets.
• dashpay/platform#3709: Both PRs change scripts/pack_dashmate.sh to restrict oclif pack release packaging targets to Node 24-compatible Linux/Windows 64-bit platforms, dropping 32-bit ones.

Suggested reviewers

• QuantumExplorer

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops with glee so bright,
Configuring targets, getting platforms right!
From linux-arm to arm64's embrace,
The dashmate builds find their proper place! 🎯

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: configuring oclif update targets in package.json and removing --targets flag from deb command.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ci/fix-dashmate-pack-node24-targets

⚔️ Resolve merge conflicts

• Resolve merge conflict in branch ci/fix-dashmate-pack-node24-targets

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[shumkov]

Superseded by #3713 (54e54d4), which landed essentially the same fix — in packages/dashmate/package.json + drop the bogus --targets on pack deb. Closing as redundant.

[shumkov]

Correction (shell ate the backticks above): the fix is oclif.update.node.targets in packages/dashmate/package.json.

[thepastaclaw]

Code Review

Small, well-scoped CI/release fix that moves dashmate's pack target list into oclif.update.node.targets so pack deb (which rejects --targets in oclif 4.0.3) inherits restricted targets, while keeping an explicit --targets override on pack tarballs to avoid emitting non-linux tarballs. Also completes the linux-arm → linux-arm64 cleanup from the prior Node 24 commit. No blocking issues.

💬 1 nitpick(s)

Inline posting hit GitHub HTTP 422, so I'm posting the verified finding in the review body instead.

nitpick: Linux targets duplicated between package.json and pack_dashmate.sh

scripts/pack_dashmate.sh:23-33

The linux subset of oclif.update.node.targets is now expressed in two places: packages/dashmate/package.json (linux-x64, linux-arm64) and scripts/pack_dashmate.sh (--targets=linux-arm64,linux-x64). Adding or removing a linux target in package.json without updating the script will cause pack tarballs to silently drift out of sync with the other pack subcommands. The script's comment already calls this out, so this is a maintainability nit — deriving the list dynamically (e.g., piping the linux-prefixed entries through jq) would remove the foot-gun.

_{source: ['claude']}

🤖 Prompt for all review comments with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `scripts/pack_dashmate.sh`:
- [NITPICK] lines 23-33: Linux targets duplicated between package.json and pack_dashmate.sh
  The linux subset of `oclif.update.node.targets` is now expressed in two places: `packages/dashmate/package.json` (`linux-x64`, `linux-arm64`) and `scripts/pack_dashmate.sh` (`--targets=linux-arm64,linux-x64`). Adding or removing a linux target in package.json without updating the script will cause `pack tarballs` to silently drift out of sync with the other pack subcommands. The script's comment already calls this out, so this is a maintainability nit — deriving the list dynamically (e.g., piping the linux-prefixed entries through `jq`) would remove the foot-gun.

Reviewed commit: 7aecc74