test(rs-sdk): expect network floor in mock sdk seed test

[thepastaclaw]

Issue being fixed or feature implemented

Fixes #3933.

The sdk_builder_default_seeds_atomic_to_floor rs-sdk integration test
still expected the raw DEFAULT_INITIAL_PROTOCOL_VERSION, but mock SDK
construction defaults to mainnet and seeds the effective protocol floor as
max(DEFAULT_INITIAL_PROTOCOL_VERSION, mainnet network floor).

What was done?

• Updated the test expectation to use
  DEFAULT_INITIAL_PROTOCOL_VERSION.max(PROTOCOL_VERSION_11).
• Adjusted the nearby comment to describe the effective floor rather than only
  the initial floor.
• Left production SDK behavior unchanged.

How Has This Been Tested?

• cargo fmt --all
• cargo test -p dash-sdk --all-features --test main fetch::document_query_v0_v1::sdk_builder_default_seeds_atomic_to_floor -- --exact --nocapture
• Pre-PR code review gate: ship

Breaking Changes

None.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the
  corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• Tests
  • Updated protocol version handling assertions to match the SDK’s new “effective floor” behavior (using the higher of the initial version and the minimum supported version).

[coderabbitai]

📝 Walkthrough

Walkthrough

The rs-sdk test now computes the expected seeded protocol version as max(INITIAL_PROTOCOL_VERSION, PROTOCOL_VERSION_11) and compares the mock SDK’s protocol version against that effective floor.

Changes

Protocol Version Floor Test Fix

Layer / File(s)	Summary
Update protocol version floor assertion packages/rs-sdk/tests/fetch/document_query_v0_v1.rs	Adds the protocol version import and updates sdk_builder_default_seeds_atomic_to_floor to assert the effective protocol version floor.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• dashpay/platform#3809: Changed default protocol-version seeding used by this test.
• dashpay/platform#3886: Added related protocol-version floor behavior.
• dashpay/platform#3900: Refactored per-network protocol-version floor semantics.

Suggested labels: ready for final review

Suggested reviewers: shumkov, quantumexplorer, claudius-maginificent, lklimek

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The test now expects the effective protocol floor, matching issue #3933's requested fix.
Out of Scope Changes check	✅ Passed	Changes stay within the test and its comment, with no unrelated code paths modified.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: updating the mock SDK seed test to expect the network floor.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

✅ Final review complete — no blockers (commit c565e77)

[thepastaclaw]

Code Review

The PR is a single test-only correction in packages/rs-sdk/tests/fetch/document_query_v0_v1.rs. Source verification confirms SdkBuilder::new_mock() defaults to mainnet and build() clamps the initial protocol version to max(DEFAULT_INITIAL_PROTOCOL_VERSION, min_protocol_version(Network::Mainnet)), so expecting max(DEFAULT_INITIAL_PROTOCOL_VERSION, PROTOCOL_VERSION_11) matches the actual SDK behavior. The targeted Cargo test could not complete because the build script needed to download Tenderdash sources and network escalation was not approved.

No active findings.

Review coverage note: Claude reviewer/verifier were unavailable due the ACP Claude limit, so this used Codex general review plus Codex verifier. The verifier inspected the pinned SHA and relevant SDK floor logic. The focused Cargo test began compiling but could not complete because the build wanted to download Tenderdash sources and network escalation was not approved.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.18%. Comparing base (a0c013f) to head (c565e77).
⚠️ Report is 93 commits behind head on v4.1-dev.

Additional details and impacted files

@@            Coverage Diff            @@
##           v4.1-dev    #3938   +/-   ##
=========================================
  Coverage     87.18%   87.18%           
=========================================
  Files          2632     2632           
  Lines        327563   327563           
=========================================
  Hits         285592   285592           
  Misses        41971    41971           

Components	Coverage Δ
dpp	87.70% <ø> (ø)
drive	86.14% <ø> (ø)
drive-abci	89.45% <ø> (ø)
sdk	∅ <ø> (∅)
dapi-client	∅ <ø> (∅)
platform-version	∅ <ø> (∅)
platform-value	92.20% <ø> (ø)
platform-wallet	∅ <ø> (∅)
drive-proof-verifier	49.55% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

Rebased on current v3.1-dev and resolved the conflict with #3900 by keeping the effective-floor assertion against INITIAL_PROTOCOL_VERSION.max(PROTOCOL_VERSION_11).\n\nValidation: cargo test -p dash-sdk --all-features --test main fetch::document_query_v0_v1::sdk_builder_default_seeds_atomic_to_floor -- --exact --nocapture.

[thepastaclaw]

Code Review

Test-only update to rs-sdk mock SDK seed expectation: assertion now computes max(INITIAL_PROTOCOL_VERSION, PROTOCOL_VERSION_11), which equals 11 and matches the mainnet floor returned by Sdk::min_protocol_version in SdkBuilder::build(). Production SDK behavior is unchanged. Both agents found nothing in scope and CodeRabbit's rate-limited summary aligns with the change; no concrete inline findings to react to.

No active findings.

Review coverage note: specialist selector chose no additional specialists; Claude and Codex general reviewers both produced parseable outputs, verifier completed cleanly, and CodeRabbit had 0 inline findings with rate-limited summary-only context. Posted as a COMMENT review because GitHub does not allow approving my own PR.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

✅ Action performed

Reviews resumed.