Skip to content

build: bump grovedb to v5.0.1#4119

Merged
QuantumExplorer merged 1 commit into
v4.1-devfrom
claude/grovedb-5-0-1-bump-056bb2
Jul 13, 2026
Merged

build: bump grovedb to v5.0.1#4119
QuantumExplorer merged 1 commit into
v4.1-devfrom
claude/grovedb-5-0-1-bump-056bb2

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Jul 13, 2026

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Bumps the pinned grovedb dependency from v5.0.0 to v5.0.1 so the workspace picks up the latest patch release.

What was done?

  • Updated every grovedb git dependency across the workspace from tag v5.0.0v5.0.1:
    • grovedb, grovedb-costs, grovedb-path, grovedb-storage, grovedb-version, grovedb-epoch-based-storage-flags, grovedb-commitment-tree
    • Touched manifests: rs-drive, rs-drive-abci, rs-dpp, rs-sdk, rs-platform-version, rs-platform-wallet
  • Regenerated Cargo.lock: all 16 grovedb-sourced crates now resolve to the v5.0.1 tag (rev 6bb2ebff).
  • The grovedb-commitment-tree bump also moves its transitive orchard dependency from dashified-0.14.0dashified-0.14.1 (orchard is not pinned directly in this repo).

No source changes were required — this is an API-compatible patch bump.

How Has This Been Tested?

  • cargo update cleanly re-resolved all grovedb crates to v5.0.1.
  • cargo check -p drive (the primary grovedb consumer — pulls grovedb, costs, path, storage, version, epoch-flags, merk, and commitment-tree) compiles successfully against v5.0.1.

Breaking Changes

None. Patch-level dependency bump with no API changes.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated underlying database and storage components to a newer maintenance release.
    • Aligned component versions across platform, wallet, SDK, and client packages for more consistent builds.
    • Preserved existing optional features and configuration settings while applying the maintenance update.

Bump all grovedb git dependencies from tag v5.0.0 to v5.0.1 across the
workspace (grovedb, grovedb-costs, grovedb-path, grovedb-storage,
grovedb-version, grovedb-epoch-based-storage-flags, grovedb-commitment-tree).

Cargo.lock is regenerated: all 16 grovedb-sourced crates now point at the
v5.0.1 tag (rev 6bb2ebff). The commitment-tree bump also moves its transitive
orchard dependency from dashified-0.14.0 to dashified-0.14.1.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions github-actions Bot added this to the v4.1.0 milestone Jul 13, 2026
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ab1d3429-35ff-4d92-9c6e-cfe047e6599d

📥 Commits

Reviewing files that changed from the base of the PR and between ccaca28 and 62d2424.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • packages/rs-dpp/Cargo.toml
  • packages/rs-drive-abci/Cargo.toml
  • packages/rs-drive/Cargo.toml
  • packages/rs-platform-version/Cargo.toml
  • packages/rs-platform-wallet/Cargo.toml
  • packages/rs-sdk/Cargo.toml

📝 Walkthrough

Walkthrough

Updates GroveDB-related git dependency tags from v5.0.0 to v5.0.1 across six Rust package manifests, preserving existing features, optionality, and dependency configuration.

Changes

GroveDB dependency tag alignment

Layer / File(s) Summary
Update GroveDB package references
packages/rs-dpp/Cargo.toml, packages/rs-drive-abci/Cargo.toml, packages/rs-drive/Cargo.toml, packages/rs-platform-version/Cargo.toml, packages/rs-platform-wallet/Cargo.toml, packages/rs-sdk/Cargo.toml
All listed grovedb* dependencies now use git tag v5.0.1; existing features, optionality, and default-feature settings are preserved.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: lklimek, shumkov, thepastaclaw

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: bumping Grovedb dependencies to v5.0.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/grovedb-5-0-1-bump-056bb2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

⛔ Blockers found — Sonnet deferred (commit 62d2424)
Canonical validated blockers: 1

@QuantumExplorer
QuantumExplorer merged commit 5f21e2a into v4.1-dev Jul 13, 2026
16 checks passed
@QuantumExplorer
QuantumExplorer deleted the claude/grovedb-5-0-1-bump-056bb2 branch July 13, 2026 22:33

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review — Codex only

The dependency pins and lockfile are internally consistent, but the GroveDB 5.0.1 bump introduces a source-breaking change through Dash SDK's public shielded API. Orchard adds a required MemoSize::MEMO_SIZE constant, so existing downstream implementations that compiled against the base revision now fail to compile.

Validated blockers were found in the Codex precheck. Sonnet is deferred until a fresh Codex revalidation clears the blocker gate.

Review provenance

  • Codex reviewers: gpt-5.6-sol — general (completed)
  • Verifier: gpt-5.6-sol — verifier
  • Sonnet: not run (deferred by blocker gate)

🔴 1 blocking

🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `packages/rs-sdk/Cargo.toml`:
- [BLOCKING] packages/rs-sdk/Cargo.toml:21-24: Dependency bump breaks downstream MemoSize implementations
  The v5.0.1 dependency resolves Orchard from dashified-0.14.0 (f055573) to dashified-0.14.1 (38ac9c1). The new source adds the required associated constant const MEMO_SIZE: usize to the public MemoSize trait without a default. GroveDB publicly re-exports both MemoSize and the types needed to implement it, and Dash SDK publicly re-exports grovedb_commitment_tree under the shielded feature. Consequently, any downstream custom MemoSize implementation valid at the base revision now fails with missing-trait-item error E0046. Preserve compatibility by publishing an upstream trait definition with a default such as const MEMO_SIZE: usize = core::mem::size_of::&lt;Self::Memo&gt;(), or treat and version the change as an intentional breaking API release before taking this dependency bump.

Comment on lines +21 to 24
grovedb-commitment-tree = { git = "https://github.com/dashpay/grovedb", tag = "v5.0.1", features = [
"client",
"sqlite",
], optional = true }

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Blocking: Dependency bump breaks downstream MemoSize implementations

The v5.0.1 dependency resolves Orchard from dashified-0.14.0 (f055573) to dashified-0.14.1 (38ac9c1). The new source adds the required associated constant const MEMO_SIZE: usize to the public MemoSize trait without a default. GroveDB publicly re-exports both MemoSize and the types needed to implement it, and Dash SDK publicly re-exports grovedb_commitment_tree under the shielded feature. Consequently, any downstream custom MemoSize implementation valid at the base revision now fails with missing-trait-item error E0046. Preserve compatibility by publishing an upstream trait definition with a default such as const MEMO_SIZE: usize = core::mem::size_of::<Self::Memo>(), or treat and version the change as an intentional breaking API release before taking this dependency bump.

source: ['codex']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants