build: bump grovedb to v5.0.1#4119
Conversation
Bump all grovedb git dependencies from tag v5.0.0 to v5.0.1 across the workspace (grovedb, grovedb-costs, grovedb-path, grovedb-storage, grovedb-version, grovedb-epoch-based-storage-flags, grovedb-commitment-tree). Cargo.lock is regenerated: all 16 grovedb-sourced crates now point at the v5.0.1 tag (rev 6bb2ebff). The commitment-tree bump also moves its transitive orchard dependency from dashified-0.14.0 to dashified-0.14.1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughUpdates GroveDB-related git dependency tags from ChangesGroveDB dependency tag alignment
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
⛔ Blockers found — Sonnet deferred (commit 62d2424) |
thepastaclaw
left a comment
There was a problem hiding this comment.
Preliminary review — Codex only
The dependency pins and lockfile are internally consistent, but the GroveDB 5.0.1 bump introduces a source-breaking change through Dash SDK's public shielded API. Orchard adds a required MemoSize::MEMO_SIZE constant, so existing downstream implementations that compiled against the base revision now fail to compile.
Validated blockers were found in the Codex precheck. Sonnet is deferred until a fresh Codex revalidation clears the blocker gate.
Review provenance
- Codex reviewers:
gpt-5.6-sol— general (completed) - Verifier:
gpt-5.6-sol— verifier - Sonnet: not run (deferred by blocker gate)
🔴 1 blocking
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `packages/rs-sdk/Cargo.toml`:
- [BLOCKING] packages/rs-sdk/Cargo.toml:21-24: Dependency bump breaks downstream MemoSize implementations
The v5.0.1 dependency resolves Orchard from dashified-0.14.0 (f055573) to dashified-0.14.1 (38ac9c1). The new source adds the required associated constant const MEMO_SIZE: usize to the public MemoSize trait without a default. GroveDB publicly re-exports both MemoSize and the types needed to implement it, and Dash SDK publicly re-exports grovedb_commitment_tree under the shielded feature. Consequently, any downstream custom MemoSize implementation valid at the base revision now fails with missing-trait-item error E0046. Preserve compatibility by publishing an upstream trait definition with a default such as const MEMO_SIZE: usize = core::mem::size_of::<Self::Memo>(), or treat and version the change as an intentional breaking API release before taking this dependency bump.
| grovedb-commitment-tree = { git = "https://github.com/dashpay/grovedb", tag = "v5.0.1", features = [ | ||
| "client", | ||
| "sqlite", | ||
| ], optional = true } |
There was a problem hiding this comment.
🔴 Blocking: Dependency bump breaks downstream MemoSize implementations
The v5.0.1 dependency resolves Orchard from dashified-0.14.0 (f055573) to dashified-0.14.1 (38ac9c1). The new source adds the required associated constant const MEMO_SIZE: usize to the public MemoSize trait without a default. GroveDB publicly re-exports both MemoSize and the types needed to implement it, and Dash SDK publicly re-exports grovedb_commitment_tree under the shielded feature. Consequently, any downstream custom MemoSize implementation valid at the base revision now fails with missing-trait-item error E0046. Preserve compatibility by publishing an upstream trait definition with a default such as const MEMO_SIZE: usize = core::mem::size_of::<Self::Memo>(), or treat and version the change as an intentional breaking API release before taking this dependency bump.
source: ['codex']
Issue being fixed or feature implemented
Bumps the pinned grovedb dependency from
v5.0.0tov5.0.1so the workspace picks up the latest patch release.What was done?
v5.0.0→v5.0.1:grovedb,grovedb-costs,grovedb-path,grovedb-storage,grovedb-version,grovedb-epoch-based-storage-flags,grovedb-commitment-treers-drive,rs-drive-abci,rs-dpp,rs-sdk,rs-platform-version,rs-platform-walletCargo.lock: all 16 grovedb-sourced crates now resolve to thev5.0.1tag (rev6bb2ebff).grovedb-commitment-treebump also moves its transitiveorcharddependency fromdashified-0.14.0→dashified-0.14.1(orchard is not pinned directly in this repo).No source changes were required — this is an API-compatible patch bump.
How Has This Been Tested?
cargo updatecleanly re-resolved all grovedb crates tov5.0.1.cargo check -p drive(the primary grovedb consumer — pulls grovedb, costs, path, storage, version, epoch-flags, merk, and commitment-tree) compiles successfully againstv5.0.1.Breaking Changes
None. Patch-level dependency bump with no API changes.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code
Summary by CodeRabbit