Skip to content

fix: prevent secret tracing in dependency build stages #4147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 2 commits into from
Jul 22, 2026
Merged

fix: prevent secret tracing in dependency build stages #4147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0389415
fix(build): prevent secret tracing in dependency stages
QuantumExplorer Jul 20, 2026
475f09f
fix(build): keep github token out of git error output
QuantumExplorer Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ ARG SDK_TEST_DATA
ARG SHIELDED_TEST_DATA
ARG ADDITIONAL_FEATURES=""

SHELL ["/bin/bash", "-o", "pipefail","-e", "-x", "-c"]
SHELL ["/bin/bash", "-o", "pipefail", "-e", "-c"]

WORKDIR /platform

Expand All @@ -462,9 +462,9 @@ RUN --mount=type=cache,sharing=shared,id=cargo_registry_index,target=${CARGO_HOM
--mount=type=cache,sharing=locked,id=cargo_git,target=${CARGO_HOME}/git/db \
--mount=type=secret,id=AWS \
--mount=type=secret,id=GITHUB_TOKEN \
set -ex; \
if [ -f /run/secrets/GITHUB_TOKEN ]; then \
git config --global url."https://$(cat /run/secrets/GITHUB_TOKEN)@github.com/".insteadOf "https://github.com/"; \
trap 'rm -f "${HOME}/.gitconfig"' EXIT; \
if [ -s /run/secrets/GITHUB_TOKEN ]; then \
git config --global url."https://x-access-token:$(cat /run/secrets/GITHUB_TOKEN)@github.com/".insteadOf "https://github.com/"; \
fi && \
source /root/env && \
export FEATURES_FLAG=""; \
Expand All @@ -491,8 +491,7 @@ RUN --mount=type=cache,sharing=shared,id=cargo_registry_index,target=${CARGO_HOM
--package drive-abci \
${FEATURES_FLAG} \
--locked && \
if [[ -x /usr/bin/sccache ]]; then sccache --show-stats; fi && \
rm -f ~/.gitconfig || true
if [[ -x /usr/bin/sccache ]]; then sccache --show-stats; fi

COPY --parents \
Cargo.lock \
Expand Down Expand Up @@ -642,8 +641,9 @@ RUN --mount=type=cache,sharing=shared,id=cargo_registry_index,target=${CARGO_HOM
--mount=type=cache,sharing=locked,id=cargo_git,target=${CARGO_HOME}/git/db \
--mount=type=secret,id=AWS \
--mount=type=secret,id=GITHUB_TOKEN \
if [ -f /run/secrets/GITHUB_TOKEN ]; then \
git config --global url."https://$(cat /run/secrets/GITHUB_TOKEN)@github.com/".insteadOf "https://github.com/"; \
trap 'rm -f "${HOME}/.gitconfig"' EXIT; \
if [ -s /run/secrets/GITHUB_TOKEN ]; then \
git config --global url."https://x-access-token:$(cat /run/secrets/GITHUB_TOKEN)@github.com/".insteadOf "https://github.com/"; \
fi && \
source /root/env && \
unset CFLAGS CXXFLAGS && \
Expand All @@ -653,8 +653,7 @@ RUN --mount=type=cache,sharing=shared,id=cargo_registry_index,target=${CARGO_HOM
--package wasm-dpp \
--target wasm32-unknown-unknown \
--locked && \
if [[ -x /usr/bin/sccache ]]; then sccache --show-stats; fi && \
rm -f ~/.gitconfig || true
if [[ -x /usr/bin/sccache ]]; then sccache --show-stats; fi


# Rust deps
Expand Down Expand Up @@ -873,7 +872,7 @@ USER node
#
FROM deps AS build-rs-dapi

SHELL ["/bin/bash", "-o", "pipefail","-e", "-x", "-c"]
SHELL ["/bin/bash", "-o", "pipefail", "-e", "-c"]

WORKDIR /platform

Expand All @@ -885,9 +884,9 @@ RUN --mount=type=cache,sharing=shared,id=cargo_registry_index,target=${CARGO_HOM
--mount=type=cache,sharing=locked,id=cargo_git,target=${CARGO_HOME}/git/db \
--mount=type=secret,id=AWS \
--mount=type=secret,id=GITHUB_TOKEN \
set -ex; \
if [ -f /run/secrets/GITHUB_TOKEN ]; then \
git config --global url."https://$(cat /run/secrets/GITHUB_TOKEN)@github.com/".insteadOf "https://github.com/"; \
trap 'rm -f "${HOME}/.gitconfig"' EXIT; \
if [ -s /run/secrets/GITHUB_TOKEN ]; then \
git config --global url."https://x-access-token:$(cat /run/secrets/GITHUB_TOKEN)@github.com/".insteadOf "https://github.com/"; \
fi && \
source /root/env && \
if [[ "${CARGO_BUILD_PROFILE}" == "release" ]] ; then \
Expand All @@ -898,8 +897,7 @@ RUN --mount=type=cache,sharing=shared,id=cargo_registry_index,target=${CARGO_HOM
--profile "$CARGO_BUILD_PROFILE" \
--package rs-dapi \
--locked && \
if [[ -x /usr/bin/sccache ]]; then sccache --show-stats; fi && \
rm -f ~/.gitconfig || true
if [[ -x /usr/bin/sccache ]]; then sccache --show-stats; fi

COPY --parents \
Cargo.lock \
Expand Down
Loading