chore(test-suite): move wallet storage persistence in the outer folder#416
Merged
Conversation
shumkov
requested changes
Jun 1, 2022
shumkov
requested changes
Jun 8, 2022
shumkov
changed the title
pshenmic
commented
Jun 9, 2022
pshenmic
marked this pull request as draft
June 9, 2022 19:11
pshenmic
marked this pull request as ready for review
June 14, 2022 11:38
# Conflicts: # yarn.lock
shumkov
reviewed
Jun 14, 2022
# Conflicts: # yarn.lock
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Each run of test suite creates temporary files in test suite package directory, and they are messing with the current git changes. In this PR, I have added a env variable for setting custom directory for storing these files. Also, configured platform test suite to store this files in platform_root_dir/db directory.
What was done?
How Has This Been Tested?
Locally + CI
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only