chore(release): update changelog and bump version to 4.1.0-beta.1#4210
Conversation
Documents the yarn release flow (scripts/release/release.sh): version derivation rules, changelog handling, preconditions, and milestone logic. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR documents the release workflow, adds the ChangesRelease preparation
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/skills/release/SKILL.md:
- Around line 21-25: Update the fenced command blocks in the release
documentation, including the block containing yarn release commands and the
additional block referenced by the comment, to declare sh or bash immediately
after each opening fence. Keep the command content unchanged.
In `@Cargo.toml`:
- Line 131: Before merging the version change to 4.1.0-beta.1, run the required
workspace checks: cargo test, cargo check, cargo clippy, and cargo fmt --check,
and ensure they all pass.
In `@CHANGELOG.md`:
- Line 402: Update the rust-dashcore changelog entry to use the rust-dashcore
issue URL and matching link text, following the established reference format
used at the other rust-dashcore entry near line 346.
- Around line 181-182: Remove the duplicated release-note bullets and issue
links throughout the 4.1.0-beta.1 changelog, including the repeated
platform-wallet entry and the additional ranges identified in the review.
Preserve one copy of each unique change and reference, without altering distinct
release notes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ef0ba3c1-f63b-4984-9322-1cfe9e0eb806
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (27)
.claude/skills/release/SKILL.mdCHANGELOG.mdCargo.tomlpackage.jsonpackages/bench-suite/package.jsonpackages/dapi-grpc/package.jsonpackages/dapi/package.jsonpackages/dash-spv/package.jsonpackages/dashmate/package.jsonpackages/dashpay-contract/package.jsonpackages/document-history-contract/package.jsonpackages/dpns-contract/package.jsonpackages/js-dapi-client/package.jsonpackages/js-dash-sdk/package.jsonpackages/js-evo-sdk/package.jsonpackages/js-grpc-common/package.jsonpackages/keyword-search-contract/package.jsonpackages/masternode-reward-shares-contract/package.jsonpackages/platform-test-suite/package.jsonpackages/token-history-contract/package.jsonpackages/wallet-lib/package.jsonpackages/wallet-utils-contract/package.jsonpackages/wasm-dpp/package.jsonpackages/wasm-dpp2/package.jsonpackages/wasm-drive-verify/package.jsonpackages/wasm-sdk/package.jsonpackages/withdrawals-contract/package.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.1-dev #4210 +/- ##
==========================================
Coverage 87.51% 87.52%
==========================================
Files 2666 2667 +1
Lines 337942 338070 +128
==========================================
+ Hits 295766 295889 +123
- Misses 42176 42181 +5
🚀 New features to boost your workflow:
|
Expose the release (and existing pr-description / simulator-control) skills to Codex via .codex/skills symlinks into .claude/skills. Ignore local Codex state but keep the shared symlinks tracked. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rs-unified-sdk-jni was added to the Cargo workspace (#4173) but never added to the Dockerfile COPY --parents lists, so in-image `cargo metadata` failed to read its manifest and the Drive / RS-DAPI / Dashmate-helper image builds broke. Include it alongside rs-unified-sdk-ffi in every full-workspace COPY stage. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The release bump set every npm package to 4.1.0-beta.1, but yarn.config.cjs requires dash-spv, dash (js-dash-sdk) and wallet-lib to lead the root major by fixed offsets (+1/+3/+7). Apply yarn constraints --fix: dash-spv 5.1.0-beta.1, dash 7.1.0-beta.1, wallet-lib 11.1.0-beta.1. Fixes the JS dependency versions check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Swift 6 strict concurrency rejected capturing [weak self] into the nonisolated Task.detached and then sending it into the main actor-isolated MainActor.run closure (AppState.swift:185, build runs warnings-as-errors). Capture [weak self] directly in the MainActor.run closure instead: AppState is @mainactor, so acquiring self inside the main-actor closure is race-free, and the detached task only carries the Sendable sdk handle and version value across isolation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Track .codex/ fully rather than ignoring local Codex state, per maintainer preference. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replace the three per-skill symlinks with a single directory symlink so every Claude skill (including emulator-control and any added later) is exposed to Codex automatically. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Tag the release-skill fenced command blocks as sh (markdownlint MD040). - Fix the rust-dashcore#913 changelog link to point at the rust-dashcore repo instead of a dashpay/platform issue URL. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Issue being fixed or feature implemented
Release new Dash Platform version
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
.codex/skills/.