Skip to content

fix(drive): db is in readonly mode due to the active transaction #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shumkov merged 2 commits into from
Oct 10, 2022
Merged

fix(drive): db is in readonly mode due to the active transaction #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c15aad6
fix(drive): db is in readonly mode due to the active transaction
shumkov Oct 10, 2022
301a7c6
test: make synchronizeMasternodeIdentitiesFactory to use transactions
shumkov Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/js-drive/lib/identity/masternode/handleRemovedMasternodeFactory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function handleRemovedMasternodeFactory(
dataContract,
'rewardShare',
document.getId(),
true,
{ useTransaction: true },
);

result.push(
Expand Down
32 changes: 22 additions & 10 deletions ...drive/test/integration/identity/masternode/synchronizeMasternodeIdentitiesFactory.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ function expectOperatorIdentityFactory(

const operatorIdentifier = createOperatorIdentifier(smlEntry);

const operatorIdentityResult = await identityRepository.fetch(operatorIdentifier);
const operatorIdentityResult = await identityRepository.fetch(
operatorIdentifier,
{ useTransaction: true },
);

const operatorIdentity = operatorIdentityResult.getValue();

Expand Down Expand Up @@ -76,7 +79,7 @@ function expectOperatorIdentityFactory(
.equal(operatorPubKey);

const firstOperatorIdentityByPublicKeyHashResult = await publicKeyToIdentitiesRepository
.fetch(firstOperatorMasternodePublicKey.hash());
.fetch(firstOperatorMasternodePublicKey.hash(), { useTransaction: true });

const firstOperatorIdentityByPublicKeyHash = firstOperatorIdentityByPublicKeyHashResult
.getValue();
Expand Down Expand Up @@ -104,7 +107,7 @@ function expectOperatorIdentityFactory(
);

const masternodeIdentityByPayoutPublicKeyHashResult = await publicKeyToIdentitiesRepository
.fetch(payoutPublicKey.hash());
.fetch(payoutPublicKey.hash(), { useTransaction: true });

const masternodeIdentityByPayoutPublicKeyHash = masternodeIdentityByPayoutPublicKeyHashResult
.getValue();
Expand All @@ -126,7 +129,7 @@ function expectOperatorIdentityFactory(
);

const masternodeIdentityByPayoutPublicKeyHashResult = await publicKeyToIdentitiesRepository
.fetch(payoutPublicKey.hash());
.fetch(payoutPublicKey.hash(), { useTransaction: true });

const masternodeIdentityByPayoutPublicKeyHash = masternodeIdentityByPayoutPublicKeyHashResult
.getValue();
Expand Down Expand Up @@ -171,7 +174,10 @@ function expectMasternodeIdentityFactory(
Buffer.from(smlEntry.proRegTxHash, 'hex'),
);

const masternodeIdentityResult = await identityRepository.fetch(masternodeIdentifier);
const masternodeIdentityResult = await identityRepository.fetch(
masternodeIdentifier,
{ useTransaction: true },
);

const masternodeIdentity = masternodeIdentityResult.getValue();

Expand All @@ -195,7 +201,7 @@ function expectMasternodeIdentityFactory(
);

const masternodeIdentityByPublicKeyHashResult = await publicKeyToIdentitiesRepository
.fetch(masternodePublicKey.hash());
.fetch(masternodePublicKey.hash(), { useTransaction: true });

const masternodeIdentityByPublicKeyHash = masternodeIdentityByPublicKeyHashResult.getValue();

Expand All @@ -217,7 +223,7 @@ function expectMasternodeIdentityFactory(
);

const masternodeIdentityByPayoutPublicKeyHashResult = await publicKeyToIdentitiesRepository
.fetch(payoutPublicKey.hash());
.fetch(payoutPublicKey.hash(), { useTransaction: true });

const masternodeIdentityByPayoutPublicKeyHash = masternodeIdentityByPayoutPublicKeyHashResult
.getValue();
Expand All @@ -239,7 +245,7 @@ function expectMasternodeIdentityFactory(
);

const masternodeIdentityByPayoutPublicKeyHashResult = await publicKeyToIdentitiesRepository
.fetch(payoutPublicKey.hash());
.fetch(payoutPublicKey.hash(), { useTransaction: true });

const masternodeIdentityByPayoutPublicKeyHash = masternodeIdentityByPayoutPublicKeyHashResult
.getValue();
Expand Down Expand Up @@ -372,14 +378,16 @@ describe('synchronizeMasternodeIdentitiesFactory', () => {

container.register('simplifiedMasternodeList', asValue(simplifiedMasternodeListMock));

const groveDBStore = container.resolve('groveDBStore');
await groveDBStore.startTransaction();

/**
* @type {Drive}
*/
const rsDrive = container.resolve('rsDrive');
await rsDrive.createInitialStateStructure();
await rsDrive.createInitialStateStructure(true);

// Create misc tree
const groveDBStore = container.resolve('groveDBStore');
await groveDBStore.createTree(
[],
Buffer.from([5]),
Expand Down Expand Up @@ -478,6 +486,7 @@ describe('synchronizeMasternodeIdentitiesFactory', () => {
['$ownerId', '==', firstMasternodeIdentifier],
['payToId', '==', firstOperatorIdentifier],
],
useTransaction: true,
},
);

Expand Down Expand Up @@ -657,6 +666,7 @@ describe('synchronizeMasternodeIdentitiesFactory', () => {
['$ownerId', '==', newMasternodeIdentifier],
['payToId', '==', newOperatorIdentifier],
],
useTransaction: true,
},
);

Expand Down Expand Up @@ -843,6 +853,7 @@ describe('synchronizeMasternodeIdentitiesFactory', () => {
where: [
['$ownerId', '==', changedMasternodeIdentifier],
],
useTransaction: true,
},
);

Expand Down Expand Up @@ -918,6 +929,7 @@ describe('synchronizeMasternodeIdentitiesFactory', () => {
where: [
['$ownerId', '==', changedMasternodeIdentifier],
],
useTransaction: true,
},
);

Expand Down