chore: remove lodash per-method deps#661
Merged
Merged
Conversation
shumkov
previously approved these changes
Dec 12, 2022
shumkov
approved these changes
Dec 12, 2022
QuantumExplorer
added a commit
that referenced
this pull request
Apr 20, 2026
PR #661 in rust-dashcore (`AssetLockResult.keys becomes an enum so both paths share the same result shape`) changed `result.keys` from a plain `Vec<[u8; 32]>` into the enum `AssetLockCreditKeys { Private(Vec<[u8; 32]>), Public(Vec<...>) }`. Our soft-wallet asset-lock builder only calls the sync `build_asset_lock`, which still returns `Private(..)`; match on that variant and extract the first key. Surface a clear error if the builder somehow returns the `Public` variant (would mean the signer path got wired in without us updating this site).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
While attempting to pack oclif bundles and update oclif to work with yarn 3, I ran into problems with requiring lodash in different ways. Requiring per-method lodash packages is no longer recommended and will result in slower build times and larger packages. These packages will be removed in lodash 5.
What was done?
Replace per-method lodash requirements with directly-required methods.
How Has This Been Tested?
Locally and in CI
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only