Skip to content

fix(dpp): can’t create fingerprint from a document transition#723

Merged
shumkov merged 1 commit into
v0.24-devfrom
fix-fingerprint
Jan 11, 2023
Merged

fix(dpp): can’t create fingerprint from a document transition#723
shumkov merged 1 commit into
v0.24-devfrom
fix-fingerprint

Conversation

@shumkov

@shumkov shumkov commented Jan 11, 2023

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

DPP tests are failing:

---- document::state_transition::documents_batch_transition::validation::basic::find_duplicates_by_id::test::test_duplicates stdout ----
thread 'document::state_transition::documents_batch_transition::validation::basic::find_duplicates_by_id::test::test_duplicates' panicked at 'called `Result::unwrap()` on an `Err` value: Can't create fingerprint from a document transition', packages/rs-dpp/src/document/state_transition/documents_batch_transition/validation/basic/find_duplicates_by_id.rs:83:62
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- tests::data_contract::state_transition::data_contract_update_transition::validation::basic::validate_indices_are_backward_compatible_spec::should_return_invalid_result_if_some_of_unique_indices_have_changed stdout ----
thread 'tests::data_contract::state_transition::data_contract_update_transition::validation::basic::validate_indices_are_backward_compatible_spec::should_return_invalid_result_if_some_of_unique_indices_have_changed' panicked at 'assertion failed: `(left == right)`
  left: `4016`,
 right: `1053`', packages/rs-dpp/src/tests/data_contract/state_transition/data_contract_update_transition/validation/basic/validate_indices_are_backward_compatible_spec.rs:96:5

---- tests::document::state_transitions::validation::validate_documents_batch_transitions_basic_spec::data_contract_id_should_be_byte_array stdout ----
thread 'tests::document::state_transitions::validation::validate_documents_batch_transitions_basic_spec::data_contract_id_should_be_byte_array' panicked at 'validation result should be returned: Error(Can't create fingerprint from a document transition)', packages/rs-dpp/src/tests/document/state_transitions/validation/validate_documents_batch_transitions_basic_spec.rs:513:6

---- tests::document::state_transitions::validation::validate_documents_batch_transitions_basic_spec::id_should_be_valid_generated_id stdout ----
thread 'tests::document::state_transitions::validation::validate_documents_batch_transitions_basic_spec::id_should_be_valid_generated_id' panicked at 'validation result should be returned: Error(Can't create fingerprint from a document transition)', packages/rs-dpp/src/tests/document/state_transitions/validation/validate_documents_batch_transitions_basic_spec.rs:677:6

---- tests::document::state_transitions::validation::validate_documents_batch_transitions_basic_spec::property_should_should_exist_with_code::_datacontractid_1025_expects stdout ----
thread 'tests::document::state_transitions::validation::validate_documents_batch_transitions_basic_spec::property_should_should_exist_with_code::_datacontractid_1025_expects' panicked at 'validation result should be returned: Error(Can't create fingerprint from a document transition)', packages/rs-dpp/src/tests/document/state_transitions/validation/validate_documents_batch_transitions_basic_spec.rs:453:6

---- tests::document::state_transitions::validation::validate_documents_batch_transitions_basic_spec::validation_should_be_successful stdout ----
thread 'tests::document::state_transitions::validation::validate_documents_batch_transitions_basic_spec::validation_should_be_successful' panicked at 'validation result should be returned: Error(Can't create fingerprint from a document transition)', packages/rs-dpp/src/tests/document/state_transitions/validation/validate_documents_batch_transitions_basic_spec.rs:929:6

What was done?

  • Changed id to $id

How Has This Been Tested?

With tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.24.0 milestone Jan 11, 2023
@shumkov
shumkov requested a review from antouhou as a code owner January 11, 2023 13:53
@shumkov
shumkov merged commit dde7c72 into v0.24-dev Jan 11, 2023
@shumkov
shumkov deleted the fix-fingerprint branch January 11, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants