Skip to content

fix(dashmate): undefined wallet for dash-cli#786

Merged
shumkov merged 1 commit into
masterfrom
fix/dashmate-seed-wallet
Feb 20, 2023
Merged

fix(dashmate): undefined wallet for dash-cli#786
shumkov merged 1 commit into
masterfrom
fix/dashmate-seed-wallet

Conversation

@pshenmic

@pshenmic pshenmic commented Feb 16, 2023

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

New v18 dashcore release introduces multi wallet support, and thus you have to point which wallet you want to use with dash-cli. At the same time, seed nodes are often used to send som dash in local networks.

What was done?

Added rpcwallet option to dash.conf template

How Has This Been Tested?

Locally

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic
pshenmic changed the base branch from v0.24-dev to master February 16, 2023 23:17
@pshenmic pshenmic added dashmate Dashmate related and removed dashmate Dashmate related labels Feb 17, 2023

@strophy strophy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this will need changing again for v19 support (like this) because wallets are no longer automatically created.

@shumkov shumkov changed the title fix(dashmate): fix dash-cli for seed nodes in local setup fix(dashmate): undefined wallet for dash-cli Feb 20, 2023
@shumkov
shumkov merged commit 2851767 into master Feb 20, 2023
@shumkov
shumkov deleted the fix/dashmate-seed-wallet branch February 20, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants