refactor(rs-dpp): bring error type to one format#804
Merged
Conversation
# Conflicts: # packages/rs-dpp/src/data_contract/data_contract_factory.rs # packages/rs-dpp/src/data_contract/state_transition/data_contract_update_transition/validation/basic/validate_data_contract_update_transition_basic.rs # packages/rs-dpp/src/decode_protocol_entity_factory.rs # packages/rs-dpp/src/document/document_stub.rs # packages/rs-dpp/src/document/state_transition/documents_batch_transition/validation/basic/validate_documents_batch_transition_basic.rs # packages/rs-dpp/src/document/state_transition/documents_batch_transition/validation/state/validate_documents_batch_transition_state.rs # packages/rs-dpp/src/errors/consensus/signature/mod.rs # packages/rs-dpp/src/errors/errors.rs # packages/rs-dpp/src/identity/state_transition/identity_credit_withdrawal_transition/validation/state/validate_identity_credit_withdrawal_transition_state.rs # packages/rs-dpp/src/identity/state_transition/identity_update_transition/apply_identity_update_transition.rs # packages/rs-dpp/src/identity/state_transition/validate_public_key_signatures.rs # packages/rs-dpp/src/state_transition/abstract_state_transition_identity_signed.rs # packages/rs-dpp/src/state_transition/state_transition_factory.rs # packages/rs-dpp/src/state_transition/validation/validate_state_transition_fee.rs # packages/rs-dpp/src/state_transition/validation/validate_state_transition_identity_signature.rs # packages/rs-dpp/src/state_transition/validation/validate_state_transition_key_signature.rs
# Conflicts: # packages/rs-dpp/src/errors/errors.rs # packages/rs-dpp/src/state_transition/validation/validate_state_transition_key_signature.rs
antouhou
marked this pull request as ready for review
February 25, 2023 11:03
# Conflicts: # packages/rs-dpp/src/data_contract/state_transition/data_contract_update_transition/validation/basic/validate_data_contract_update_transition_basic.rs
shuplenkov
changed the title
llbartekll
added a commit
that referenced
this pull request
Jun 8, 2026
dashpay/rust-dashcore#804 ("fix(key-wallet): correct CoinJoin discovery") is merged into dev. Switch the 8 workspace rust-dashcore crates from the prior pinned rev (eb889af) to dev's HEAD 7ff6b246 — the #804 merge commit — so the CoinJoin sweep/recovery stack builds against the merged fix instead of the pre-merge PR branch. cargo check -p platform-wallet -p platform-wallet-ffi passes; Cargo.lock updated (same 0.43.0 versions, source rev only). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
llbartekll
added a commit
that referenced
this pull request
Jun 8, 2026
dashpay/rust-dashcore#804 ("fix(key-wallet): correct CoinJoin discovery") is merged into dev. Switch the 8 workspace rust-dashcore crates from the prior pinned rev (eb889af) to dev's HEAD 7ff6b246 — the #804 merge commit — so the CoinJoin sweep/recovery stack builds against the merged fix instead of the pre-merge PR branch. cargo check -p platform-wallet -p platform-wallet-ffi passes; Cargo.lock updated (same 0.43.0 versions, source rev only). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only