feat(wasm-dpp): state transition facade#814
Merged
Merged
Conversation
markin-io
commented
Mar 9, 2023
markin-io
commented
Mar 9, 2023
markin-io
commented
Mar 9, 2023
QuantumExplorer
previously approved these changes
Mar 13, 2023
antouhou
reviewed
Mar 14, 2023
antouhou
reviewed
Mar 14, 2023
antouhou
reviewed
Mar 14, 2023
antouhou
reviewed
Mar 14, 2023
antouhou
reviewed
Mar 14, 2023
antouhou
reviewed
Mar 14, 2023
antouhou
approved these changes
Mar 15, 2023
shumkov
added a commit
that referenced
this pull request
Jun 19, 2026
…ork() removal Updates all 8 rust-dashcore workspace deps 981e97f1 -> ceee4a9b40 (dev HEAD), which picks up #813 (DashPay account-index derivation path) and #814 (revert of the temporary #808 Core 23 nested-masternode-address SML changes), so platform keeps the existing flat-field masternode shape and no consensus change is needed. The bump also crosses #802 (removed Address::network(), replaced Network with AddressPrefix because an address's prefix is ambiguous across testnet/devnet and legacy-regtest). Migrate the four call sites: - wasm-sdk validate_address: addr.is_valid_for_network(net) — a bool, exactly what it computed and now correct for the shared testnet/devnet prefix. - platform-wallet derivation_path_for_derived_address: the path only distinguishes mainnet (coin 5') from everything else (1'), so probe is_valid_for_network(Mainnet). - platform-wallet-ffi address rendering (2 sites): an address_display_network helper probes mainnet/testnet/regtest, decisive for the bech32m platform-payment addresses rendered here (mainnet ds / testnet+devnet tb / regtest dsrt). Migration tracked in #3939. Full workspace --all-targets compiles. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Implements State Transition Facade, it's binding and wasm-dpp tests
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only