Skip to content

chore(sdk): add eslint#827

Merged
markin-io merged 14 commits into
v0.24-devfrom
chore/sdk/add-eslint
Mar 17, 2023
Merged

chore(sdk): add eslint#827
markin-io merged 14 commits into
v0.24-devfrom
chore/sdk/add-eslint

Conversation

@markin-io

@markin-io markin-io commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Adds eslint

What was done?

  • Added eslint package for typescript with airbnb config, handled JS files as well
  • Changed certain from errors into warnings in order to not drown in long refactoring which could possibly break some code (check warnRules in .eslintrc.js)
  • Manually fixed eslint errors that do not alter logical constructions (missing vars, long lines, rearranging imports and etc)
  • eslint-ignored errors that require changes in logical constructions and could possibly cause bugs

How Has This Been Tested?

  • CI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-io
markin-io marked this pull request as draft March 16, 2023 17:33
@markin-io markin-io added this to the v0.24.0 milestone Mar 16, 2023
@markin-io
markin-io marked this pull request as ready for review March 16, 2023 17:42
antouhou
antouhou previously approved these changes Mar 17, 2023
@markin-io
markin-io merged commit 2cf7273 into v0.24-dev Mar 17, 2023
@markin-io
markin-io deleted the chore/sdk/add-eslint branch March 17, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants