chore(release): update changelog and bump version to 0.24.0-dev.14#833
Merged
Conversation
shuplenkov
approved these changes
Mar 20, 2023
5 tasks
shumkov
added a commit
that referenced
this pull request
Jul 4, 2026
Bring the branch up to v4.1-dev, which bumps rust-dashcore to afcff156:
key-wallet now impls `Zeroize` + `Drop` on `ExtendedPrivKey`, and
`extended_public_key` moved into the new `ExtendedPubKeySigner` subtrait.
Conflicts resolved (take base's rust-dashcore, afcff156):
- Cargo.toml / Cargo.lock: base's afcff156 rev.
- packages/rs-sdk-ffi/src/mnemonic_resolver_core_signer.rs: reconcile the
derive-sign-destroy zeroization with the upstream change.
- `WipingXprv` REMOVED — it was a local workaround for `ExtendedPrivKey`
having no `Drop`, which key-wallet now provides (dashcore PR #833, added
specifically for this signer). The bare value self-wipes on every path.
- `WipingSecretKey` KEPT — the `secp256k1::SecretKey` copy at the two sign
sites is the one key intermediate #833 cannot cover (`SecretKey` is an
upstream type with no `Zeroize`, only `non_secure_erase()`), so the RAII
guard remains the only way to close its `?`-early-return / panic leak
window. Preserves the "no key bytes survive the trait boundary" invariant.
- `extended_public_key` moved into an `impl ExtendedPubKeySigner` block
(dashcore #839).
Bump ripple + follow-through:
- packages/rs-platform-wallet-ffi/src/dashpay.rs: import `ExtendedPubKeySigner`
for `receiving_xpub` (the method moved off `Signer`).
- packages/rs-platform-wallet-ffi/src/sign_with_mnemonic_resolver.rs: drop its
own now-redundant `WipingXprv`, relying on `ExtendedPrivKey`'s upstream Drop.
rs-sdk-ffi + platform-wallet-ffi build; 300 + 8 tests pass (incl. the 12
resolver-signer tests); full-workspace build green; fmt + clippy clean.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Release new Dash Platform version
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only