Skip to content

chore(drive): temporary disable payout script#835

Merged
shumkov merged 2 commits into
v0.24-devfrom
disable-masternode-identity-keys
Mar 21, 2023
Merged

chore(drive): temporary disable payout script#835
shumkov merged 2 commits into
v0.24-devfrom
disable-masternode-identity-keys

Conversation

@shumkov

@shumkov shumkov commented Mar 21, 2023

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

[2023-03-21 04:51:46.315 +0000] FATAL (35 on 81a4ef41c2a0): identity: a unique key with that hash already exists: the key already exists in the unique set
    driveVersion: "0.24.0-dev.14"
    height: "1"
    abciMethod: "initChain"
    err: {
      "type": "Error",
      "message": "identity: a unique key with that hash already exists: the key already exists in the unique set",
      "stack":
          Error: identity: a unique key with that hash already exists: the key already exists in the unique set
              at Object.appendStackWrapper (/platform/packages/rs-drive-nodejs/appendStack.js:10:18)
              at async IdentityStoreRepository.create (/platform/packages/js-drive/lib/identity/IdentityStoreRepository.js:164:25)
              at async createMasternodeIdentity (/platform/packages/js-drive/lib/identity/masternode/createMasternodeIdentityFactory.js:72:5)
              at async handleNewMasternode (/platform/packages/js-drive/lib/identity/masternode/handleNewMasternodeFactory.js:55:7)
              at async synchronizeMasternodeIdentities (/platform/packages/js-drive/lib/identity/masternode/synchronizeMasternodeIdentitiesFactory.js:214:32)
              at async initChainHandler (/platform/packages/js-drive/lib/abci/handlers/initChainHandlerFactory.js:87:51)
              at async Connection.handleRequest (/platform/.yarn/cache/@dashevo-abci-https-9fb519f2ca-aaf41ab7fa.zip/node_modules/@dashevo/abci/lib/handleRequestFactory.js:55:29)
              at async Connection.readNextRequest (/platform/.yarn/cache/@dashevo-abci-https-9fb519f2ca-aaf41ab7fa.zip/node_modules/@dashevo/abci/lib/Connection.js:176:18)
    }

Devnets are using the same payout script for all masternodes, which is fine. But DPP doesn't support non-unique keys atm so Drive creates masternode identities with unique keys only.

What was done?

  • Temporary disable payout key for masternode identity until we have support of non-unique keys in DPP

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.24.0 milestone Mar 21, 2023
@shumkov
shumkov requested a review from antouhou as a code owner March 21, 2023 06:55
@shumkov
shumkov merged commit dd230dc into v0.24-dev Mar 21, 2023
@shumkov
shumkov deleted the disable-masternode-identity-keys branch March 21, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants