feat(wasm-dpp) fix unused tests and tests in Document, DocumentFactory and DataContractFactory#850
Merged
Merged
Conversation
# Conflicts: # packages/wasm-dpp/lib/test/fixtures/getIdentityUpdateTransitionFixture.js # packages/wasm-dpp/lib/test/fixtures/getInstantAssetLockProofFixture.js # packages/wasm-dpp/test/integration/document/Document.spec.js
# Conflicts: # packages/rs-dpp/src/document/document_factory.rs
# Conflicts: # packages/wasm-dpp/lib/test/fixtures/getIdentityCreateTransitionFixture.js # packages/wasm-dpp/lib/test/fixtures/getIdentityFixture.js
antouhou
changed the title
antouhou
marked this pull request as ready for review
March 27, 2023 07:24
markin-io
approved these changes
Mar 27, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Some tests for documents and data contract weren't function properly or we failing
What was done?
Fix tests; Fix some bugs in the implementation; Moved all fixtures from js-dpp to wasm-dpp
How Has This Been Tested?
Run tests
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only