build(rs-drive-abci): update Dockerfile to Alpine and build correctly on ARM64#859
Merged
Conversation
lklimek
marked this pull request as ready for review
March 24, 2023 16:42
lklimek
requested review from
strophy
and removed request for
antouhou and
shumkov
March 24, 2023 16:42
shumkov
requested changes
Mar 25, 2023
lklimek
changed the title
shumkov
reviewed
Mar 29, 2023
shumkov
changed the title
shumkov
approved these changes
Apr 1, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
As learned from dashpay/rs-tenderdash-abci#14 , cargo build takes too many resources on ARM64 target in github actions. This causes Arm64 image build to fail.
What was done?
Added
--config net.git-fetch-with-cli=trueto address ARM build issue. See rust-lang/cargo#10781 (comment)Replace Debian base image with Apline.
How Has This Been Tested?
On rs-tenderdash-abci, similar solution fixed the arm64 build issue: https://github.com/dashpay/rs-tenderdash-abci/actions/runs/4512281223
Locally, it also passes:
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only