refactor(dashmate): always keep platform config

packages/dashmate/configs/migrations.js

@@ -480,6 +480,8 @@ module.exports = {
       .forEach(([name, config]) => {
         if (config.platform) {
           config.platform.enable = name !== 'mainnet';
+        } else {
+          config.platform = (systemConfigs[name] || systemConfigs.base).platform;
         }
 
         if (systemConfigs[name]) {

packages/dashmate/src/commands/reset.js

@@ -32,7 +32,7 @@ class ResetCommand extends ConfigBaseCommand {
       throw new Error(`Cannot hard reset non-system config "${config.getName()}"`);
     }
 
-    if (!config.isPlatformEnabled() && isPlatformOnlyReset) {
+    if (!config.get('platform.enable') && isPlatformOnlyReset) {
       throw new Error('Cannot reset platform only if platform services are not enabled in config');
     }
 

packages/dashmate/src/commands/status/platform.js

@@ -27,7 +27,7 @@ class PlatformStatusCommand extends ConfigBaseCommand {
     config,
     getPlatformScope,
   ) {
-    if (!config.isPlatformEnabled()) {
+    if (!config.get('platform.enable')) {
       throw new Error('Platform is not supported for this node type and network');
     }
 

packages/dashmate/src/config/Config.js

@@ -104,16 +104,6 @@ class Config {
     return this;
   }
 
-  /**
-   * Remove by path
-   *
-   * @param {string} path
-   * @returns {Config}
-   */
-  remove(path) {
-    return this.set(path, undefined);
-  }
-
   /**
    * Get options
    *
@@ -171,7 +161,7 @@ class Config {
       dockerComposeFiles.push('docker-compose.sentinel.yml');
     }
 
-    if (this.isPlatformEnabled()) {
+    if (this.get('platform.enable')) {
       dockerComposeFiles.push('docker-compose.platform.yml');
 
       if (this.get('platform.sourcePath') !== null) {
@@ -188,7 +178,7 @@ class Config {
       ...convertObjectToEnvs(this.getOptions()),
     };
 
-    if (this.isPlatformEnabled()) {
+    if (this.get('platform.enable')) {
       envs = {
         ...envs,
 
@@ -212,14 +202,6 @@ class Config {
 
     return envs;
   }
-
-  /**
-   *
-   * @returns {boolean}
-   */
-  isPlatformEnabled() {
-    return this.has('platform') && this.get('platform.enable');
-  }
 }
 
 Config.ajv = new Ajv({ coerceTypes: true });

packages/dashmate/src/listr/tasks/resetNodeTaskFactory.js

@@ -37,7 +37,7 @@ function resetNodeTaskFactory(
       },
       {
         title: 'Remove platform services and associated data',
-        enabled: (ctx) => ctx.isPlatformOnlyReset && config.isPlatformEnabled(),
+        enabled: (ctx) => ctx.isPlatformOnlyReset && config.get('platform.enable'),
         task: async () => {
           // Remove containers
           const coreContainerNames = ['core', 'sentinel'];

packages/dashmate/src/listr/tasks/setup/local/configureTenderdashTaskFactory.js

@@ -19,7 +19,7 @@ function configureTenderdashTaskFactory(
     return new Listr([
       {
         task: async (ctx) => {
-          const platformConfigs = configGroup.filter((config) => config.isPlatformEnabled());
+          const platformConfigs = configGroup.filter((config) => config.get('platform.enable'));
 
           const subTasks = [];
 

packages/dashmate/src/listr/tasks/setup/regular/configureSSLCertificateTaskFactory.js

@@ -94,7 +94,6 @@ function configureSSLCertificateTaskFactory(
       {
         title: 'Configure SSL certificate',
         task: async (ctx, task) => {
-          // TODO Move to upper function to show output in upper task?
           const choices = [
             { name: SSL_PROVIDERS.ZEROSSL, message: 'ZeroSSL' },
             { name: SSL_PROVIDERS.FILE, message: 'File on disk' },

packages/dashmate/src/listr/tasks/setup/setupLocalPresetTaskFactory.js

@@ -189,7 +189,7 @@ function setupLocalPresetTaskFactory(
                   config.set('core.miner.enable', true);
 
                   // Disable platform for the seed node
-                  config.remove('platform');
+                  config.set('platform.enable', false);
                 } else {
                   config.set('description', `local node #${nodeIndex}`);
 

packages/dashmate/src/listr/tasks/setup/setupRegularPresetTaskFactory.js

@@ -81,10 +81,7 @@ function setupRegularPresetTaskFactory(
 
           ctx.config = new Config(ctx.preset, systemConfigs[ctx.preset]);
 
-          if (!ctx.isHP) {
-            delete ctx.config.remove('platform');
-          }
-
+          ctx.config.set('platform.enable', ctx.isHP);
           ctx.config.set('core.masternode.enable', ctx.nodeType === NODE_TYPE_MASTERNODE);
 
           // eslint-disable-next-line no-param-reassign
@@ -132,7 +129,7 @@ function setupRegularPresetTaskFactory(
         task: () => configureNodeTask(),
       },
       {
-        enabled: (ctx) => ctx.config && ctx.config.isPlatformEnabled(),
+        enabled: (ctx) => ctx.config && ctx.config.get('platform.enable'),
         task: () => configureSSLCertificateTask(),
       },
       {

packages/dashmate/src/listr/tasks/ssl/selfSigned/obtainSelfSignedCertificateTaskFactory.js

@@ -22,7 +22,7 @@ function obtainSelfSignedCertificateTaskFactory(
     return new Listr([
       {
         task: async (ctx) => {
-          const platformConfigs = configGroup.filter((config) => config.isPlatformEnabled());
+          const platformConfigs = configGroup.filter((config) => config.get('platform.enable'));
 
           const subTasks = platformConfigs.map((config) => ({
             title: `Create certificate for ${config.getName()}`,

packages/dashmate/src/listr/tasks/startGroupNodesTaskFactory.js

@@ -38,7 +38,7 @@ function startGroupNodesTaskFactory(
     ));
 
     const platformBuildConfig = configGroup.find((config) => (
-      config.has('platform.sourcePath') && config.get('platform.sourcePath') !== null
+      config.get('platform.enable') && config.get('platform.sourcePath') !== null
     ));
 
     return new Listr([
@@ -155,7 +155,7 @@ function startGroupNodesTaskFactory(
         enabled: (ctx) => Boolean(ctx.waitForReadiness),
         task: () => {
           const tasks = configGroup
-            .filter((config) => config.isPlatformEnabled())
+            .filter((config) => config.get('platform.enable'))
             .map((config) => ({
               title: `Wait for ${config.getName()} node`,
               task: () => waitForNodeToBeReadyTask(config),

packages/dashmate/src/listr/tasks/startNodeTaskFactory.js

@@ -47,7 +47,7 @@ function startNodeTaskFactory(
     }
 
     // Check Drive log files are created
-    if (config.isPlatformEnabled()) {
+    if (config.get('platform.enable')) {
       const prettyFilePath = config.get('platform.drive.abci.log.prettyFile.path');
 
       // Remove directory that could potentially be created by Docker mount
@@ -84,7 +84,7 @@ function startNodeTaskFactory(
       },
       {
         enabled: (ctx) => !ctx.skipBuildServices
-          && config.has('platform.sourcePath')
+          && config.get('platform.enable')
           && config.get('platform.sourcePath') !== null,
         task: () => buildServicesTask(config),
       },

packages/dashmate/src/status/scopes/overview.js

@@ -44,7 +44,7 @@ function getOverviewScopeFactory(getCoreScope,
     };
 
     const platform = {
-      enabled: config.isPlatformEnabled(),
+      enabled: config.get('platform.enable'),
       tenderdash: null,
     };
 
@@ -59,7 +59,7 @@ function getOverviewScopeFactory(getCoreScope,
       masternode.nodeState = nodeState;
     }
 
-    if (config.isPlatformEnabled()) {
+    if (config.get('platform.enable')) {
       const { tenderdash } = await getPlatformScope(config);
 
       platform.tenderdash = tenderdash;

packages/dashmate/src/status/scopes/services.js

@@ -25,7 +25,7 @@ function getServicesScopeFactory(dockerCompose) {
       });
     }
 
-    if (config.isPlatformEnabled()) {
+    if (config.get('platform.enable')) {
       Object.assign(serviceHumanNames, {
         drive_abci: 'Drive ABCI',
         drive_tenderdash: 'Drive Tenderdash',

packages/dashmate/src/templates/renderServiceTemplatesFactory.js

@@ -24,7 +24,7 @@ function renderServiceTemplatesFactory() {
       .sync(`${templatesPath}/**/*.dot`)
       // Do not render platform templates if it's not configured
       .filter((templatePath) => (
-        !templatePath.includes('templates/platform') || config.isPlatformEnabled()
+        !templatePath.includes('templates/platform') || config.get('platform.enable')
       ));
 
     const configFiles = {};

packages/dashmate/test/unit/status/scopes/overview.spec.js

@@ -20,7 +20,6 @@ describe('getOverviewScopeFactory', () => {
       config = {
         get: this.sinon.stub(),
         toEnvs: this.sinon.stub(),
-        isPlatformEnabled: this.sinon.stub(),
       };
 
       getOverviewScope = getOverviewScopeFactory(mockGetCoreScope,
@@ -74,7 +73,7 @@ describe('getOverviewScopeFactory', () => {
     });
 
     it('should not load if masternode or platform disabled ', async () => {
-      config.isPlatformEnabled.returns(false);
+      config.get.withArgs('platform.enable').returns(false);
       config.get.withArgs('core.masternode.enable').returns(false);
       config.get.withArgs('network').returns('mainnet');
 

packages/dashmate/test/unit/status/scopes/platform.spec.js

@@ -40,7 +40,6 @@ describe('getPlatformScopeFactory', () => {
       config = {
         get: this.sinon.stub(),
         toEnvs: this.sinon.stub(),
-        isPlatformEnabled: this.sinon.stub(),
       };
 
       getPlatformScope = getPlatformScopeFactory(mockDockerCompose,

packages/dashmate/test/unit/status/scopes/services.spec.js

@@ -13,7 +13,6 @@ describe('getServicesScopeFactory', () => {
       config = {
         get: this.sinon.stub(),
         toEnvs: this.sinon.stub(),
-        isPlatformEnabled: this.sinon.stub(),
       };
 
       getServicesScope = getServicesScopeFactory(mockDockerCompose);