fix: possible overflow issues#877
Merged
Merged
Conversation
qrayven
marked this pull request as ready for review
March 31, 2023 10:39
# Conflicts: # packages/rs-dpp/src/identity/state_transition/identity_update_transition/validate_identity_update_transition_state.rs
markin-io
pushed a commit
that referenced
this pull request
Apr 26, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
5 tasks
markin-io
pushed a commit
that referenced
this pull request
Apr 26, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
6 tasks
bfoss765
added a commit
to bfoss765/platform
that referenced
this pull request
Jul 14, 2026
…edes local dashpay#873 vendor) Testing dashpay#866+dashpay#851 at gap 30 pending on-device verdict. Swaps OUR dashpay#846 committed-range fix for hash's alternative (rust-dashcore PR dashpay#866, `rescan_committed_range`: newly derived scripts are re-tested against the persisted committed filter range below the committing batch), adds PR dashpay#851 (the dashpay#649 out-of-order spend-before-funding UTXO fix), and forces DEFAULT_COINJOIN_GAP_LIMIT to 30 in the vendored third_party/rust-dashcore — to test on-device whether hash's fixes make the narrower gap viable on the heaviest CoinJoin wallet, instead of the dashj-parity widening to 100 (dashpay#868). Vendored tree transform (third_party/rust-dashcore): - REMOVED our dashpay#846 machinery (drain_committed_rescans / committed_filters retention across the commit boundary). - APPLIED PR dashpay#866 (2 commits: 8ccba0b6 rescan committed ranges + 381a4fec defer backward sweep to forward quiescence). Ships its own coinjoin_gap_discovery_tests.rs — the committed-batch repro (coinjoin_gap_limit_stall_across_committed_batch) is the GREEN guard under his mechanism; our identical-scenario port is superseded (same path, and its setup assumed our retention machinery). - APPLIED PR dashpay#851 (dashpay#649 out-of-order spend fix; the 27-commit linear chain only, excluding the dev merges it carried — dashpay#867/dashpay#868/dashpay#877/…). - DEFAULT_COINJOIN_GAP_LIMIT 100 -> 30, doc rewritten to state the experiment honestly. - PRESERVED the asset-lock router fix (CoinJoin + DashPay in the AssetLock arm of get_relevant_account_types) and rust-dashcore dashpay#863. Companion test change (packages/rs-platform-wallet/.../asset_lock/build.rs): coinjoin_gap_limit_discovers_addresses_beyond_the_old_window now tracks DEFAULT_COINJOIN_GAP_LIMIT (asserts cj.gap_limit() == the constant and probes far_index = constant - 1) instead of hardcoding 100 / index 50, so it stays a valid far-edge discovery regression check at any gap; adds coinjoin_gap_limit_is_experiment_value_30 pinning the compiled constant. Verification: cargo test green — dash-spv 475, key-wallet 569, key-wallet-manager 46 (in the standalone clone composite); platform-wallet 438. AAR republished to mavenLocal (org.dashj:dash-sdk-android:0.1.0-SNAPSHOT); natives carry rescan_committed_range symbols and no drain_committed_rescans. Known-good dashpay#873/gap-100 AAR backed up at 0.1.0-SNAPSHOT.bak-873-gap100. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
The PR fixes potential overflow panics for artithmetic operations
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only