chore(wasm-dpp): proper identifier buffer inheritance#879
Merged
markin-io merged 24 commits intoApr 3, 2023
Conversation
markin-io
changed the title
markin-io
marked this pull request as ready for review
March 31, 2023 19:11
markin-io
changed the title
antouhou
approved these changes
Apr 3, 2023
QuantumExplorer
pushed a commit
that referenced
this pull request
Apr 20, 2023
markin-io
pushed a commit
that referenced
this pull request
Apr 24, 2023
6 tasks
QuantumExplorer
added a commit
that referenced
this pull request
Jul 14, 2026
…on persisted provider accounts Deletes platform-wallet's duplicated pre-#879 hybrid derivation: all operator/platform-node key derivation now delegates to the corrected upstream key-wallet primitives (gate-free variants usable on resident and watch-only wallets), and the FFI mnemonic resolver preserves the raw BIP39 seed instead of collapsing it to a secp256k1 master. The operator ownership map indexes both BLS serializations (v1 ProRegTx payloads carry legacy bytes). Persisted provider account xpubs are stamped with a derivation-version marker; unstamped (pre-fix) rows are skipped at load with a warning so stale keys are never shown or matched — a wallet re-import regenerates them correctly. Golden-vector tests pin the derivation to upstream's dashbls reference values, and a cross-path test asserts both derivation entry points agree; user-verified against dashwallet-ios (DashSync) with a shared mnemonic on mainnet. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
QuantumExplorer
added a commit
that referenced
this pull request
Jul 14, 2026
The pre-#879 derivation never shipped, so the version-magic machinery guarded a dev-only transient state that delete+re-import cures. Provider xpubs persist as raw bincode like every other account; a comment records the accepted consequence for pre-fix dev wallets. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Issues
identifierhas to be replaced withidentifier.toBuffer()identifierwe have to writeBuffer.from(identifier.toBuffer())What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only