feat(rs-drive-abci): generate validator set for tenderdash#880
Merged
Conversation
lklimek
force-pushed
the
feat-validator-set
branch
from
April 3, 2023 15:19
d17d6f7 to
db765e6
Compare
QuantumExplorer
marked this pull request as ready for review
April 3, 2023 15:27
QuantumExplorer
approved these changes
Apr 3, 2023
| "use-serde", | ||
| ], default-features = false, rev = "51548a4a1b9eca7430f5f3caf94d9784886ff2e9" } | ||
| dashcore-rpc = { git = "https://github.com/jawid-h/rust-dashcore-rpc", branch = "fix/attempt-to-fix" } | ||
| dashcore-rpc = { git = "https://github.com/dashevo/rust-dashcore-rpc" } # path = "../../../rust-dashcore-rpc/client" |
Member
There was a problem hiding this comment.
no it should be
dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore-rpc" } # path = "../../../rust-dashcore-rpc/client"
| } | ||
|
|
||
| /// Helper function to convert bytes into bls12381 public key, as required by Tenderdash | ||
| fn u8_to_bls12381_pubkey(public_key: Vec<u8>) -> abci_crypto::PublicKey { |
Member
There was a problem hiding this comment.
I think it's best to have a method in the crate
QuantumExplorer
added a commit
that referenced
this pull request
Jul 14, 2026
…er via rust-dashcore#881 Bumps the pin to bc6cbf96 picking up the gate-free provider-key API (dashpay/rust-dashcore#881, from our #880): operator_public_key_at / operator_private_key_at / platform_node_key_at. All derivation composition in provider_key_at_index.rs is deleted — platform now resolves wallets, calls upstream, and maps types. The private-reveal keeps an always-on consistency check (secret's pubkey must equal the xpub-derived one; the two upstream paths derive from independent sources and don't verify each other). Provider key accounts are also routed through the address-pool restore so their persisted rows rehydrate the in-memory pools at load (used-flags and beyond-gap indices survive restarts). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Tenderdash needs to receive validator set updates when quorums are rotated.
What was done?
Added validator_set module that allows easy generation of validator set update, required by Tenderdash.
Implemented From trait to allow easy conversion from validator_set::ValidatorSet into tenderdash's ValidatorSetUpdate.
To use:
How Has This Been Tested?
Small unit test
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only