feat(rs-drive-abci): withdrawal processing using vote extensions#891
Merged
Conversation
QuantumExplorer
marked this pull request as ready for review
April 6, 2023 20:23
QuantumExplorer
added a commit
that referenced
this pull request
Jul 14, 2026
…ernode aggregation Bump rust-dashcore to 38c689d9 (#891, fixes #890): block processing now stamps each retained record's BlockInfo with its block.vtx index, and chainlock promotion preserves it. - provider_masternode_txs_blocking reads block_info.position() instead of the previous position = 0 placeholder, so same-block provider updates aggregate in Core's apply order. - The position round-trips persistence: TransactionRecordFFI and PersistentTransaction carry block_position/has_block_position, and the provider special-tx staging path restores it onto the rebuilt record's BlockInfo. Rows persisted before the field existed restore as None and fall back to feed order among themselves. - Round-trip test covers both the flagged and pre-field cases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
shumkov
added a commit
that referenced
this pull request
Jul 14, 2026
…y-invitations Both sides had bumped rust-dashcore past the PlatformNodeId newtype (#885): v4.1-dev's #4120 pinned 38c689d9 (a descendant of this branch's ac8828c9, adding #889 canonical byte order + #891 tx-record positions), so the dependency block resolves to v4.1-dev's newer rev — git's auto-merge had duplicated the whole [workspace.dependencies] table, so it was reconciled by hand back to a single block. peers.rs and core_wallet_types.rs take v4.1-dev's variants of the same PlatformNodeId adaptations both sides had made independently. persistence.rs: #4120 extracted the load-side pool-restore loop into restore_core_address_pools() with funds + provider-key routing, but the extraction was based on v4.1-dev's copy and so dropped this branch's asset-lock funding-account arms (identity registration / top-up / invitation / address top-up) — the voucher-key-reuse restore fix. The merge takes the helper and re-adds those six arms (with the security rationale comment); the FFIPersister durability attestation from the round-5 fix is preserved. Post-merge: workspace check + clippy --all-features + fmt clean; platform-wallet 460 and platform-wallet-ffi 169 tests green (both suites now include the base's new provider-key restore tests). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Withdrawal transactions need to use vote extensions in their processing
What was done?
How Has This Been Tested?
Not tested at all yet
Breaking Changes
Checklist:
For repository code-owners and collaborators only