fix(rs-drive-abci): config file is broken#892
Merged
Conversation
lklimek
requested review from
QuantumExplorer
and removed request for
antouhou and
shumkov
April 6, 2023 20:52
shumkov
approved these changes
Apr 7, 2023
QuantumExplorer
added a commit
that referenced
this pull request
Jul 15, 2026
…rows + land the #893 crash-fix pin Follow-up to #4129 (merged before its review completed) addressing thepastaclaw's blocking finding, plus the rust-dashcore bump that was pushed to the #4129 branch after its merge and never landed: - restore_address_pool: a legacy row persisted before the typed-key column (empty key -> public_key: None) no longer strips the typed BLS key the gap-limit prederivation put at the same index — pre-typed-key stores otherwise lose in-memory operator pubkeys at load and masternode operator-ownership matching silently breaks. No-op for post-migration rows (they always carry their key). Test pins both directions. Legacy Ed25519 platform-node keys are hardened-only and their old account-level batch was dropped by the schema migration, so they cannot be recovered at load; per the pre-release convention those stores re-derive on delete+re-import. - PersistentCoreAddress.keyType doc: corrected the false "re-tags on every load" claim — load only reads the snapshot; re-tagging happens on the next persist pulse. - Bump rust-dashcore to 19690d31 (merged #893, fixes #892): the sparse-filter startup crash-loop fix, verified live on the previously crash-looping simulator state. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Envy doesn't handle correctly int values inside flattened structs. See softprops/envy#26
What was done?
How Has This Been Tested?
Breaking Changes
none
Checklist:
For repository code-owners and collaborators only