feat(dpp): all changes from v24-wasm-integration#905
Closed
antouhou wants to merge 13 commits into
Closed
Conversation
antouhou
marked this pull request as ready for review
April 10, 2023 14:20
antouhou
changed the title
shumkov
reviewed
Apr 10, 2023
| // we want to skip serialization of transitions, as we does it manually in `to_object()` and `to_json()` | ||
| #[serde(skip_serializing)] | ||
| // we want to skip serialization of transitions, as we do it manually in `to_object()` and `to_json()` | ||
| // #[serde(skip_serializing)] |
Contributor
Author
There was a problem hiding this comment.
I'm not sure what to do about this one - this one was done for a reason, but it broke stuff. So while we're not 100% sure (it seems like it doesn't) it doesn't break anything I would keep it here
Collaborator
There was a problem hiding this comment.
Let's bring it back then? My point was that we shouldn't commit commented code.
shumkov
reviewed
Apr 10, 2023
| .is_in_the_valid_master_nodes_list(context.owner_id.to_buffer()) | ||
| .await?; | ||
|
|
||
| // // Do not allow creating document if ownerId is not in SML |
Collaborator
There was a problem hiding this comment.
We should add a todo here
Collaborator
|
@antouhou what we are going to do with this PR? |
Contributor
Author
|
Closing, as it has been split into several smaller PRs |
Collaborator
|
It was merge with multiple separate PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
js components not functioning properly
What was done?
Lots of things
How Has This Been Tested?
Run tests, run test suite from another branch
Breaking Changes
Some, probably
Checklist:
For repository code-owners and collaborators only