Skip to content

fix(drive): total HPMNs contains all masternodes #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shumkov merged 1 commit into from
Apr 13, 2023
Merged

fix(drive): total HPMNs contains all masternodes #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/js-drive/lib/abci/handlers/proposal/beginBlockFactory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
const { hash } = require('@dashevo/dpp/lib/util/hash');

const { MASTERNODE_TYPE_HP } = require('@dashevo/dashcore-lib/lib/constants');

const NotSupportedNetworkProtocolVersionError = require('../errors/NotSupportedNetworkProtocolVersionError');
const NetworkProtocolVersionIsNotSetError = require('../errors/NetworkProtocolVersionIsNotSetError');

Expand Down Expand Up @@ -147,6 +149,7 @@ function beginBlockFactory(
totalHpmns: simplifiedMasternodeList.getStore()
.getCurrentSML()
.getValidMasternodesList()
.filter((smlEntry) => smlEntry.nType === MASTERNODE_TYPE_HP)
.length,
proposedAppVersion: proposedAppVersion.toNumber(),
};
Expand Down
5 changes: 1 addition & 4 deletions packages/js-drive/test/unit/abci/handlers/proposal/beginBlockFactory.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ describe('beginBlockFactory', () => {
let time;
let lastSyncedCoreHeightRepositoryMock;
let simplifyMasternodeListMock;
let validMasternodesListLength;

beforeEach(function beforeEach() {
round = 0;
Expand Down Expand Up @@ -117,15 +116,13 @@ describe('beginBlockFactory', () => {
}),
};

validMasternodesListLength = 400;

simplifyMasternodeListMock = {
getStore() {
return {
getCurrentSML() {
return {
getValidMasternodesList() {
return validMasternodesListLength;
return new Array(400);
},
};
},
Expand Down